You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by Alexei Fedotov <al...@gmail.com> on 2013/05/31 10:57:40 UTC
Re: svn commit: r1488124 - in /openmeetings/branches/2.1:
WebContent/openmeetings/openmeetings_functions.js WebContent/src/base/externalJavaScript.lzx
WebContent/src/main.lzx WebContent/swf10/base/mainMethods.lzx src/usual_template.vm
We have discussed that a bit on the private list. Let me continue here.
Most of problems of 2.1 release were intermittent. They include thread
safety issues, sound quality issues, and incorrect resource clean up.
Developers do not address them because there is no simple and known
way to reproduce them, it requires a lot of digging, debugging. and,
what is most important, collecting data. Another reason is "we need to
dig into openlaszlo, which is obsolete".
With disabling public error collection feature, I can no longer
provide statistics that some problem exist. I do not argue that
neglecting problems works well with problems, the problem is that it
makes nearly impossible keeping even existing end users. The end users
face intermittent problems and leave.
I also don't think reverting patches of another committer is a good
practice unless we somehow agree that the patch should be reverted.
--
With best regards / с наилучшими пожеланиями,
Alexei Fedotov / Алексей Федотов,
http://dataved.ru/
+7 916 562 8095
On Fri, May 31, 2013 at 11:59 AM, <so...@apache.org> wrote:
> Author: solomax
> Date: Fri May 31 07:59:12 2013
> New Revision: 1488124
>
> URL: http://svn.apache.org/r1488124
> Log:
> Hardcoded Google-Analytics support is removed
>
> Modified:
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> openmeetings/branches/2.1/WebContent/src/main.lzx
> openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> openmeetings/branches/2.1/src/usual_template.vm
>
> Modified: openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> URL: http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js?rev=1488124&r1=1488123&r2=1488124&view=diff
> ==============================================================================
> --- openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js (original)
> +++ openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js Fri May 31 07:59:12 2013
> @@ -23,20 +23,6 @@
> *
> */
>
> -var _gaq;
> -
> -function sendErrorReport(message) {
> - // Google Analytics
> - try {
> - _gaq = _gaq || [];
> - _gaq.push(['_setAccount', 'UA-13024987-1']);
> - _gaq.push(['_trackPageview']);
> - _gaq.push(['_trackEvent', 'Openmeetings client error', message, '', 0, true]);
> - } catch (exception) {
> - alert(exception);
> - }
> -}
> -
> function getBrowserInfo() {
> //alert(navigator.userAgent);
> document.getElementById("lzapp").getBrowserInfoCallback(navigator.userAgent);
>
> Modified: openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> URL: http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx?rev=1488124&r1=1488123&r2=1488124&view=diff
> ==============================================================================
> --- openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx (original)
> +++ openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx Fri May 31 07:59:12 2013
> @@ -35,10 +35,6 @@
> var browserInfoReturnObject = null;
> var browserLangReturnObject = null;
>
> - function sendErrorReport(message) {
> - lz.Browser.callJS('sendErrorReport', null, message);
> - }
> -
> function redirectToUrl(url, returnObject) {
>
> redirectToUrlReturnObject = returnObject;
>
> Modified: openmeetings/branches/2.1/WebContent/src/main.lzx
> URL: http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/src/main.lzx?rev=1488124&r1=1488123&r2=1488124&view=diff
> ==============================================================================
> --- openmeetings/branches/2.1/WebContent/src/main.lzx (original)
> +++ openmeetings/branches/2.1/WebContent/src/main.lzx Fri May 31 07:59:12 2013
> @@ -59,10 +59,6 @@
> canvas.lc = new LocalConnection();
> </handler>
>
> -<handler name="onerror" args="errmsg">
> - sendErrorReport(errmsg);
> -</handler>
> -
> <!-- View for Contents. All Windows will be loaded on this view. -->
> <view name="main_content" y="${ canvas.naviHeightDelta }" width="${canvas.width}"
> height="${ canvas.height-canvas.naviHeightDelta }"
>
> Modified: openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> URL: http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx?rev=1488124&r1=1488123&r2=1488124&view=diff
> ==============================================================================
> --- openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx (original)
> +++ openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx Fri May 31 07:59:12 2013
> @@ -23,15 +23,8 @@
>
> <library>
>
> - <method name="onError" args="errorEvent">
> - lz.Browser.callJS('sendErrorReport', null, errorEvent.toString());
> - </method>
> -
> <method name="myinit">
> <![CDATA[
> - // Add listener to all uncaught errors
> - this.getDisplayObject().loaderInfo.addEventListener(UncaughtErrorEvent.UNCAUGHT_ERROR, onError);
> -
> canvas.mediaerrortimeout = 30000;
> canvas.medialoadtimeout = 30000;
>
>
> Modified: openmeetings/branches/2.1/src/usual_template.vm
> URL: http://svn.apache.org/viewvc/openmeetings/branches/2.1/src/usual_template.vm?rev=1488124&r1=1488123&r2=1488124&view=diff
> ==============================================================================
> --- openmeetings/branches/2.1/src/usual_template.vm (original)
> +++ openmeetings/branches/2.1/src/usual_template.vm Fri May 31 07:59:12 2013
> @@ -54,8 +54,6 @@ limitations under the License.
> <script type="text/javascript"
> src="embed-compressed.js"></script>
> <script type="text/javascript"
> - src="http://www.google-analytics.com/ga.js"></script>
> -<script type="text/javascript"
> src="openmeetings_functions.js"></script>
> <script type="text/javascript">
>
>
>
Re: svn commit: r1488124 - in /openmeetings/branches/2.1:
WebContent/openmeetings/openmeetings_functions.js WebContent/src/base/externalJavaScript.lzx
WebContent/src/main.lzx WebContent/swf10/base/mainMethods.lzx src/usual_template.vm
Posted by Maxim Solodovnik <so...@gmail.com>.
no reports are sent to FF without confirmation
IMHO coockie is not enough here
On Fri, May 31, 2013 at 5:48 PM, Alexei Fedotov <al...@gmail.com>wrote:
> I wrote,
>
> >> Adding a cookie check and a single popup if the cookie is not set for
> disabling error data sending would take 20 minutes anyway. Does this work
> for you?
>
> There was no answer to this from you. I expected you at least to
> hint why you are unhappy with the patch.
>
> If this is a proper direction of patch improvement. I
> personally think collecting error data can be done without notice -
> most of web sites do this.
>
> 1. The argument "other open source products do not collect user
> data" does not work, let me repeat the example [1].
> 2. The argument "this is against law" is invalid, the patch does not
> collect user personal data.
>
> [1]
> https://crash-stats.mozilla.com/report/index/050f1aab-1507-4c8f-a166-9b3322130422
>
>
> --
> With best regards / с наилучшими пожеланиями,
> Alexei Fedotov / Алексей Федотов,
> http://dataved.ru/
> +7 916 562 8095
>
>
> On Fri, May 31, 2013 at 2:40 PM, Maxim Solodovnik <so...@gmail.com>
> wrote:
> > Hello Alexey,
> >
> > The patch was reverted after long discussion (still continued).
> > I did ask to change it with no result.
> >
> > I'm going to announce 2.1.1 next Monday, so no time to wait any longer.
> > Additionally please see my answer in the other thread.
> >
> >
> >
> > On Fri, May 31, 2013 at 3:57 PM, Alexei Fedotov <
> alexei.fedotov@gmail.com>wrote:
> >
> >> We have discussed that a bit on the private list. Let me continue here.
> >>
> >> Most of problems of 2.1 release were intermittent. They include thread
> >> safety issues, sound quality issues, and incorrect resource clean up.
> >> Developers do not address them because there is no simple and known
> >> way to reproduce them, it requires a lot of digging, debugging. and,
> >> what is most important, collecting data. Another reason is "we need to
> >> dig into openlaszlo, which is obsolete".
> >>
> >> With disabling public error collection feature, I can no longer
> >> provide statistics that some problem exist. I do not argue that
> >> neglecting problems works well with problems, the problem is that it
> >> makes nearly impossible keeping even existing end users. The end users
> >> face intermittent problems and leave.
> >>
> >> I also don't think reverting patches of another committer is a good
> >> practice unless we somehow agree that the patch should be reverted.
> >> --
> >> With best regards / с наилучшими пожеланиями,
> >> Alexei Fedotov / Алексей Федотов,
> >> http://dataved.ru/
> >> +7 916 562 8095
> >>
> >>
> >> On Fri, May 31, 2013 at 11:59 AM, <so...@apache.org> wrote:
> >> > Author: solomax
> >> > Date: Fri May 31 07:59:12 2013
> >> > New Revision: 1488124
> >> >
> >> > URL: http://svn.apache.org/r1488124
> >> > Log:
> >> > Hardcoded Google-Analytics support is removed
> >> >
> >> > Modified:
> >> >
> >>
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> >> >
> openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> >> > openmeetings/branches/2.1/WebContent/src/main.lzx
> >> > openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> >> > openmeetings/branches/2.1/src/usual_template.vm
> >> >
> >> > Modified:
> >>
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> >> > URL:
> >>
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js?rev=1488124&r1=1488123&r2=1488124&view=diff
> >> >
> >>
> ==============================================================================
> >> > ---
> >>
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> >> (original)
> >> > +++
> >>
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> >> Fri May 31 07:59:12 2013
> >> > @@ -23,20 +23,6 @@
> >> > *
> >> > */
> >> >
> >> > -var _gaq;
> >> > -
> >> > -function sendErrorReport(message) {
> >> > - // Google Analytics
> >> > - try {
> >> > - _gaq = _gaq || [];
> >> > - _gaq.push(['_setAccount', 'UA-13024987-1']);
> >> > - _gaq.push(['_trackPageview']);
> >> > - _gaq.push(['_trackEvent', 'Openmeetings client error',
> >> message, '', 0, true]);
> >> > - } catch (exception) {
> >> > - alert(exception);
> >> > - }
> >> > -}
> >> > -
> >> > function getBrowserInfo() {
> >> > //alert(navigator.userAgent);
> >> >
> >>
> document.getElementById("lzapp").getBrowserInfoCallback(navigator.userAgent);
> >> >
> >> > Modified:
> >> openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> >> > URL:
> >>
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx?rev=1488124&r1=1488123&r2=1488124&view=diff
> >> >
> >>
> ==============================================================================
> >> > ---
> openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> >> (original)
> >> > +++
> openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> >> Fri May 31 07:59:12 2013
> >> > @@ -35,10 +35,6 @@
> >> > var browserInfoReturnObject = null;
> >> > var browserLangReturnObject = null;
> >> >
> >> > - function sendErrorReport(message) {
> >> > - lz.Browser.callJS('sendErrorReport', null, message);
> >> > - }
> >> > -
> >> > function redirectToUrl(url, returnObject) {
> >> >
> >> > redirectToUrlReturnObject = returnObject;
> >> >
> >> > Modified: openmeetings/branches/2.1/WebContent/src/main.lzx
> >> > URL:
> >>
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/src/main.lzx?rev=1488124&r1=1488123&r2=1488124&view=diff
> >> >
> >>
> ==============================================================================
> >> > --- openmeetings/branches/2.1/WebContent/src/main.lzx (original)
> >> > +++ openmeetings/branches/2.1/WebContent/src/main.lzx Fri May 31
> >> 07:59:12 2013
> >> > @@ -59,10 +59,6 @@
> >> > canvas.lc = new LocalConnection();
> >> > </handler>
> >> >
> >> > -<handler name="onerror" args="errmsg">
> >> > - sendErrorReport(errmsg);
> >> > -</handler>
> >> > -
> >> > <!-- View for Contents. All Windows will be loaded on this view. -->
> >> > <view name="main_content" y="${ canvas.naviHeightDelta }"
> >> width="${canvas.width}"
> >> > height="${
> >> canvas.height-canvas.naviHeightDelta }"
> >> >
> >> > Modified:
> openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> >> > URL:
> >>
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx?rev=1488124&r1=1488123&r2=1488124&view=diff
> >> >
> >>
> ==============================================================================
> >> > --- openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> >> (original)
> >> > +++ openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> Fri
> >> May 31 07:59:12 2013
> >> > @@ -23,15 +23,8 @@
> >> >
> >> > <library>
> >> >
> >> > - <method name="onError" args="errorEvent">
> >> > - lz.Browser.callJS('sendErrorReport', null,
> >> errorEvent.toString());
> >> > - </method>
> >> > -
> >> > <method name="myinit">
> >> > <![CDATA[
> >> > - // Add listener to all uncaught errors
> >> > -
> >>
> this.getDisplayObject().loaderInfo.addEventListener(UncaughtErrorEvent.UNCAUGHT_ERROR,
> >> onError);
> >> > -
> >> > canvas.mediaerrortimeout = 30000;
> >> > canvas.medialoadtimeout = 30000;
> >> >
> >> >
> >> > Modified: openmeetings/branches/2.1/src/usual_template.vm
> >> > URL:
> >>
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/src/usual_template.vm?rev=1488124&r1=1488123&r2=1488124&view=diff
> >> >
> >>
> ==============================================================================
> >> > --- openmeetings/branches/2.1/src/usual_template.vm (original)
> >> > +++ openmeetings/branches/2.1/src/usual_template.vm Fri May 31
> 07:59:12
> >> 2013
> >> > @@ -54,8 +54,6 @@ limitations under the License.
> >> > <script type="text/javascript"
> >> > src="embed-compressed.js"></script>
> >> > <script type="text/javascript"
> >> > - src="http://www.google-analytics.com/ga.js"></script>
> >> > -<script type="text/javascript"
> >> > src="openmeetings_functions.js"></script>
> >> > <script type="text/javascript">
> >> >
> >> >
> >> >
> >>
> >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
>
--
WBR
Maxim aka solomax
Re: svn commit: r1488124 - in /openmeetings/branches/2.1:
WebContent/openmeetings/openmeetings_functions.js WebContent/src/base/externalJavaScript.lzx
WebContent/src/main.lzx WebContent/swf10/base/mainMethods.lzx src/usual_template.vm
Posted by Alexei Fedotov <al...@gmail.com>.
I wrote,
>> Adding a cookie check and a single popup if the cookie is not set for disabling error data sending would take 20 minutes anyway. Does this work for you?
There was no answer to this from you. I expected you at least to
hint why you are unhappy with the patch.
If this is a proper direction of patch improvement. I
personally think collecting error data can be done without notice -
most of web sites do this.
1. The argument "other open source products do not collect user
data" does not work, let me repeat the example [1].
2. The argument "this is against law" is invalid, the patch does not
collect user personal data.
[1] https://crash-stats.mozilla.com/report/index/050f1aab-1507-4c8f-a166-9b3322130422
--
With best regards / с наилучшими пожеланиями,
Alexei Fedotov / Алексей Федотов,
http://dataved.ru/
+7 916 562 8095
On Fri, May 31, 2013 at 2:40 PM, Maxim Solodovnik <so...@gmail.com> wrote:
> Hello Alexey,
>
> The patch was reverted after long discussion (still continued).
> I did ask to change it with no result.
>
> I'm going to announce 2.1.1 next Monday, so no time to wait any longer.
> Additionally please see my answer in the other thread.
>
>
>
> On Fri, May 31, 2013 at 3:57 PM, Alexei Fedotov <al...@gmail.com>wrote:
>
>> We have discussed that a bit on the private list. Let me continue here.
>>
>> Most of problems of 2.1 release were intermittent. They include thread
>> safety issues, sound quality issues, and incorrect resource clean up.
>> Developers do not address them because there is no simple and known
>> way to reproduce them, it requires a lot of digging, debugging. and,
>> what is most important, collecting data. Another reason is "we need to
>> dig into openlaszlo, which is obsolete".
>>
>> With disabling public error collection feature, I can no longer
>> provide statistics that some problem exist. I do not argue that
>> neglecting problems works well with problems, the problem is that it
>> makes nearly impossible keeping even existing end users. The end users
>> face intermittent problems and leave.
>>
>> I also don't think reverting patches of another committer is a good
>> practice unless we somehow agree that the patch should be reverted.
>> --
>> With best regards / с наилучшими пожеланиями,
>> Alexei Fedotov / Алексей Федотов,
>> http://dataved.ru/
>> +7 916 562 8095
>>
>>
>> On Fri, May 31, 2013 at 11:59 AM, <so...@apache.org> wrote:
>> > Author: solomax
>> > Date: Fri May 31 07:59:12 2013
>> > New Revision: 1488124
>> >
>> > URL: http://svn.apache.org/r1488124
>> > Log:
>> > Hardcoded Google-Analytics support is removed
>> >
>> > Modified:
>> >
>> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
>> > openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
>> > openmeetings/branches/2.1/WebContent/src/main.lzx
>> > openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
>> > openmeetings/branches/2.1/src/usual_template.vm
>> >
>> > Modified:
>> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
>> > URL:
>> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js?rev=1488124&r1=1488123&r2=1488124&view=diff
>> >
>> ==============================================================================
>> > ---
>> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
>> (original)
>> > +++
>> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
>> Fri May 31 07:59:12 2013
>> > @@ -23,20 +23,6 @@
>> > *
>> > */
>> >
>> > -var _gaq;
>> > -
>> > -function sendErrorReport(message) {
>> > - // Google Analytics
>> > - try {
>> > - _gaq = _gaq || [];
>> > - _gaq.push(['_setAccount', 'UA-13024987-1']);
>> > - _gaq.push(['_trackPageview']);
>> > - _gaq.push(['_trackEvent', 'Openmeetings client error',
>> message, '', 0, true]);
>> > - } catch (exception) {
>> > - alert(exception);
>> > - }
>> > -}
>> > -
>> > function getBrowserInfo() {
>> > //alert(navigator.userAgent);
>> >
>> document.getElementById("lzapp").getBrowserInfoCallback(navigator.userAgent);
>> >
>> > Modified:
>> openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
>> > URL:
>> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx?rev=1488124&r1=1488123&r2=1488124&view=diff
>> >
>> ==============================================================================
>> > --- openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
>> (original)
>> > +++ openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
>> Fri May 31 07:59:12 2013
>> > @@ -35,10 +35,6 @@
>> > var browserInfoReturnObject = null;
>> > var browserLangReturnObject = null;
>> >
>> > - function sendErrorReport(message) {
>> > - lz.Browser.callJS('sendErrorReport', null, message);
>> > - }
>> > -
>> > function redirectToUrl(url, returnObject) {
>> >
>> > redirectToUrlReturnObject = returnObject;
>> >
>> > Modified: openmeetings/branches/2.1/WebContent/src/main.lzx
>> > URL:
>> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/src/main.lzx?rev=1488124&r1=1488123&r2=1488124&view=diff
>> >
>> ==============================================================================
>> > --- openmeetings/branches/2.1/WebContent/src/main.lzx (original)
>> > +++ openmeetings/branches/2.1/WebContent/src/main.lzx Fri May 31
>> 07:59:12 2013
>> > @@ -59,10 +59,6 @@
>> > canvas.lc = new LocalConnection();
>> > </handler>
>> >
>> > -<handler name="onerror" args="errmsg">
>> > - sendErrorReport(errmsg);
>> > -</handler>
>> > -
>> > <!-- View for Contents. All Windows will be loaded on this view. -->
>> > <view name="main_content" y="${ canvas.naviHeightDelta }"
>> width="${canvas.width}"
>> > height="${
>> canvas.height-canvas.naviHeightDelta }"
>> >
>> > Modified: openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
>> > URL:
>> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx?rev=1488124&r1=1488123&r2=1488124&view=diff
>> >
>> ==============================================================================
>> > --- openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
>> (original)
>> > +++ openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx Fri
>> May 31 07:59:12 2013
>> > @@ -23,15 +23,8 @@
>> >
>> > <library>
>> >
>> > - <method name="onError" args="errorEvent">
>> > - lz.Browser.callJS('sendErrorReport', null,
>> errorEvent.toString());
>> > - </method>
>> > -
>> > <method name="myinit">
>> > <![CDATA[
>> > - // Add listener to all uncaught errors
>> > -
>> this.getDisplayObject().loaderInfo.addEventListener(UncaughtErrorEvent.UNCAUGHT_ERROR,
>> onError);
>> > -
>> > canvas.mediaerrortimeout = 30000;
>> > canvas.medialoadtimeout = 30000;
>> >
>> >
>> > Modified: openmeetings/branches/2.1/src/usual_template.vm
>> > URL:
>> http://svn.apache.org/viewvc/openmeetings/branches/2.1/src/usual_template.vm?rev=1488124&r1=1488123&r2=1488124&view=diff
>> >
>> ==============================================================================
>> > --- openmeetings/branches/2.1/src/usual_template.vm (original)
>> > +++ openmeetings/branches/2.1/src/usual_template.vm Fri May 31 07:59:12
>> 2013
>> > @@ -54,8 +54,6 @@ limitations under the License.
>> > <script type="text/javascript"
>> > src="embed-compressed.js"></script>
>> > <script type="text/javascript"
>> > - src="http://www.google-analytics.com/ga.js"></script>
>> > -<script type="text/javascript"
>> > src="openmeetings_functions.js"></script>
>> > <script type="text/javascript">
>> >
>> >
>> >
>>
>
>
>
> --
> WBR
> Maxim aka solomax
Re: svn commit: r1488124 - in /openmeetings/branches/2.1:
WebContent/openmeetings/openmeetings_functions.js WebContent/src/base/externalJavaScript.lzx
WebContent/src/main.lzx WebContent/swf10/base/mainMethods.lzx src/usual_template.vm
Posted by Maxim Solodovnik <so...@gmail.com>.
Hello Alexey,
The patch was reverted after long discussion (still continued).
I did ask to change it with no result.
I'm going to announce 2.1.1 next Monday, so no time to wait any longer.
Additionally please see my answer in the other thread.
On Fri, May 31, 2013 at 3:57 PM, Alexei Fedotov <al...@gmail.com>wrote:
> We have discussed that a bit on the private list. Let me continue here.
>
> Most of problems of 2.1 release were intermittent. They include thread
> safety issues, sound quality issues, and incorrect resource clean up.
> Developers do not address them because there is no simple and known
> way to reproduce them, it requires a lot of digging, debugging. and,
> what is most important, collecting data. Another reason is "we need to
> dig into openlaszlo, which is obsolete".
>
> With disabling public error collection feature, I can no longer
> provide statistics that some problem exist. I do not argue that
> neglecting problems works well with problems, the problem is that it
> makes nearly impossible keeping even existing end users. The end users
> face intermittent problems and leave.
>
> I also don't think reverting patches of another committer is a good
> practice unless we somehow agree that the patch should be reverted.
> --
> With best regards / с наилучшими пожеланиями,
> Alexei Fedotov / Алексей Федотов,
> http://dataved.ru/
> +7 916 562 8095
>
>
> On Fri, May 31, 2013 at 11:59 AM, <so...@apache.org> wrote:
> > Author: solomax
> > Date: Fri May 31 07:59:12 2013
> > New Revision: 1488124
> >
> > URL: http://svn.apache.org/r1488124
> > Log:
> > Hardcoded Google-Analytics support is removed
> >
> > Modified:
> >
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> > openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> > openmeetings/branches/2.1/WebContent/src/main.lzx
> > openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> > openmeetings/branches/2.1/src/usual_template.vm
> >
> > Modified:
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> > URL:
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js?rev=1488124&r1=1488123&r2=1488124&view=diff
> >
> ==============================================================================
> > ---
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> (original)
> > +++
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> Fri May 31 07:59:12 2013
> > @@ -23,20 +23,6 @@
> > *
> > */
> >
> > -var _gaq;
> > -
> > -function sendErrorReport(message) {
> > - // Google Analytics
> > - try {
> > - _gaq = _gaq || [];
> > - _gaq.push(['_setAccount', 'UA-13024987-1']);
> > - _gaq.push(['_trackPageview']);
> > - _gaq.push(['_trackEvent', 'Openmeetings client error',
> message, '', 0, true]);
> > - } catch (exception) {
> > - alert(exception);
> > - }
> > -}
> > -
> > function getBrowserInfo() {
> > //alert(navigator.userAgent);
> >
> document.getElementById("lzapp").getBrowserInfoCallback(navigator.userAgent);
> >
> > Modified:
> openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> > URL:
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx?rev=1488124&r1=1488123&r2=1488124&view=diff
> >
> ==============================================================================
> > --- openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> (original)
> > +++ openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> Fri May 31 07:59:12 2013
> > @@ -35,10 +35,6 @@
> > var browserInfoReturnObject = null;
> > var browserLangReturnObject = null;
> >
> > - function sendErrorReport(message) {
> > - lz.Browser.callJS('sendErrorReport', null, message);
> > - }
> > -
> > function redirectToUrl(url, returnObject) {
> >
> > redirectToUrlReturnObject = returnObject;
> >
> > Modified: openmeetings/branches/2.1/WebContent/src/main.lzx
> > URL:
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/src/main.lzx?rev=1488124&r1=1488123&r2=1488124&view=diff
> >
> ==============================================================================
> > --- openmeetings/branches/2.1/WebContent/src/main.lzx (original)
> > +++ openmeetings/branches/2.1/WebContent/src/main.lzx Fri May 31
> 07:59:12 2013
> > @@ -59,10 +59,6 @@
> > canvas.lc = new LocalConnection();
> > </handler>
> >
> > -<handler name="onerror" args="errmsg">
> > - sendErrorReport(errmsg);
> > -</handler>
> > -
> > <!-- View for Contents. All Windows will be loaded on this view. -->
> > <view name="main_content" y="${ canvas.naviHeightDelta }"
> width="${canvas.width}"
> > height="${
> canvas.height-canvas.naviHeightDelta }"
> >
> > Modified: openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> > URL:
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx?rev=1488124&r1=1488123&r2=1488124&view=diff
> >
> ==============================================================================
> > --- openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> (original)
> > +++ openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx Fri
> May 31 07:59:12 2013
> > @@ -23,15 +23,8 @@
> >
> > <library>
> >
> > - <method name="onError" args="errorEvent">
> > - lz.Browser.callJS('sendErrorReport', null,
> errorEvent.toString());
> > - </method>
> > -
> > <method name="myinit">
> > <![CDATA[
> > - // Add listener to all uncaught errors
> > -
> this.getDisplayObject().loaderInfo.addEventListener(UncaughtErrorEvent.UNCAUGHT_ERROR,
> onError);
> > -
> > canvas.mediaerrortimeout = 30000;
> > canvas.medialoadtimeout = 30000;
> >
> >
> > Modified: openmeetings/branches/2.1/src/usual_template.vm
> > URL:
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/src/usual_template.vm?rev=1488124&r1=1488123&r2=1488124&view=diff
> >
> ==============================================================================
> > --- openmeetings/branches/2.1/src/usual_template.vm (original)
> > +++ openmeetings/branches/2.1/src/usual_template.vm Fri May 31 07:59:12
> 2013
> > @@ -54,8 +54,6 @@ limitations under the License.
> > <script type="text/javascript"
> > src="embed-compressed.js"></script>
> > <script type="text/javascript"
> > - src="http://www.google-analytics.com/ga.js"></script>
> > -<script type="text/javascript"
> > src="openmeetings_functions.js"></script>
> > <script type="text/javascript">
> >
> >
> >
>
--
WBR
Maxim aka solomax