You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "tomtongue (via GitHub)" <gi...@apache.org> on 2025/05/08 06:34:20 UTC

[PR] Spark 3.4: Migrate the remaining `SparkCatalogTestBase` related tests and remove `SparkCatalogTestBase` [iceberg]

tomtongue opened a new pull request, #13007:
URL: https://github.com/apache/iceberg/pull/13007

   *Migrate Spark 3.4 tests based on JUnit 4 to Junit5 with AssertJ style. This is related to https://github.com/apache/iceberg/issues/7160*
   
   This PR migrates the following `SparkCatalogTestBase` related tests to JUnit 5 with AssertJ:
   
   * `TestSparkTable`
   * `TestStructuredStreamingRead3`
   * `TestCompressionSettings` including the test backport from https://github.com/apache/iceberg/pull/11333
   * `TestRequiredDistributionAndOrdering`
   * `TestSparkStagedScan`
   
   Plus, additional one: `TestRuntimeFiltering`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] Spark 3.4: Migrate the remaining `SparkCatalogTestBase` related tests and remove `SparkCatalogTestBase` [iceberg]

Posted by "tomtongue (via GitHub)" <gi...@apache.org>.
tomtongue commented on code in PR #13007:
URL: https://github.com/apache/iceberg/pull/13007#discussion_r2079275533


##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkTable.java:
##########
@@ -28,7 +29,9 @@
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.TestTemplate;
+import org.junit.jupiter.api.extension.ExtendWith;
 
+@ExtendWith(ParameterizedTestExtension.class)

Review Comment:
   Okay got it. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] Spark 3.4: Migrate the remaining `SparkCatalogTestBase` related tests and remove `SparkCatalogTestBase` [iceberg]

Posted by "tomtongue (via GitHub)" <gi...@apache.org>.
tomtongue commented on PR #13007:
URL: https://github.com/apache/iceberg/pull/13007#issuecomment-2862161937

   @nastra Could you review this PR as well? This PR will remove the `SparkCatalogTestBase` class. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] Spark 3.4: Migrate the remaining `SparkCatalogTestBase` related tests and remove `SparkCatalogTestBase` [iceberg]

Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #13007:
URL: https://github.com/apache/iceberg/pull/13007#discussion_r2079255373


##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkTable.java:
##########
@@ -28,7 +29,9 @@
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.TestTemplate;
+import org.junit.jupiter.api.extension.ExtendWith;
 
+@ExtendWith(ParameterizedTestExtension.class)

Review Comment:
   FYI that Spark 4 now made it into the codebase, so we should eventually also sync up 3.5 <-> 4.0 tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] Spark 3.4: Migrate the remaining `SparkCatalogTestBase` related tests and remove `SparkCatalogTestBase` [iceberg]

Posted by "tomtongue (via GitHub)" <gi...@apache.org>.
tomtongue commented on PR #13007:
URL: https://github.com/apache/iceberg/pull/13007#issuecomment-2862370687

   @nastra Thank you for reviewing this PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] Spark 3.4: Migrate the remaining `SparkCatalogTestBase` related tests and remove `SparkCatalogTestBase` [iceberg]

Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #13007:
URL: https://github.com/apache/iceberg/pull/13007


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org