You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/03/31 22:00:56 UTC
Review Request 32698: Used the argv version of subprocess for linux
perf utilities.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32698/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
Repository: mesos
Description
-------
Used the argv version of subprocess for linux perf utilities. See discussion in MESOS-2462. This is to prepare for the death signal patch.
Diffs
-----
src/linux/perf.cpp 863aa4a972289a59f57e93cd06ba2bf9df949fe2
Diff: https://reviews.apache.org/r/32698/diff/
Testing
-------
Thanks,
Jie Yu
Re: Review Request 32698: Used the argv version of subprocess for
linux perf utilities.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32698/#review78545
-----------------------------------------------------------
Ship it!
src/linux/perf.cpp
<https://reviews.apache.org/r/32698/#comment127389>
Not yours but the delimiter doesn't need to be attached to the flag so it's cleaner to have it as a separate argument now:
{noformat}
-x SEP, --field-separator SEP
print counts using a CSV-style output to make it easy to import directly into spreadsheets. Columns are separated by the string specified in SEP.
{noformat}
src/linux/perf.cpp
<https://reviews.apache.org/r/32698/#comment127388>
ditto
- Ian Downes
On March 31, 2015, 1:04 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32698/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 1:04 p.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: MESOS-2462
> https://issues.apache.org/jira/browse/MESOS-2462
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used the argv version of subprocess for linux perf utilities. See discussion in MESOS-2462. This is to prepare for the death signal patch.
>
>
> Diffs
> -----
>
> src/linux/perf.cpp 863aa4a972289a59f57e93cd06ba2bf9df949fe2
>
> Diff: https://reviews.apache.org/r/32698/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 32698: Used the argv version of subprocess for
linux perf utilities.
Posted by Jie Yu <yu...@gmail.com>.
> On April 1, 2015, 10:38 p.m., Ben Mahler wrote:
> > src/linux/perf.cpp, line 131
> > <https://reviews.apache.org/r/32698/diff/2/?file=912580#file912580line131>
> >
> > Do you need the named 'argv' or can you return the initializer list directly?
Yes, the following code does not compile on gcc-4.4:
```
return {
...
};
```
I can do
```
return vector<string>({
...
});
```
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32698/#review78612
-----------------------------------------------------------
On April 1, 2015, 7:40 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32698/
> -----------------------------------------------------------
>
> (Updated April 1, 2015, 7:40 p.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: MESOS-2462
> https://issues.apache.org/jira/browse/MESOS-2462
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used the argv version of subprocess for linux perf utilities. See discussion in MESOS-2462. This is to prepare for the death signal patch.
>
>
> Diffs
> -----
>
> src/linux/perf.cpp 863aa4a972289a59f57e93cd06ba2bf9df949fe2
>
> Diff: https://reviews.apache.org/r/32698/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 32698: Used the argv version of subprocess for
linux perf utilities.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32698/#review78612
-----------------------------------------------------------
Ship it!
src/linux/perf.cpp
<https://reviews.apache.org/r/32698/#comment127528>
Do you need the named 'argv' or can you return the initializer list directly?
- Ben Mahler
On April 1, 2015, 7:40 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32698/
> -----------------------------------------------------------
>
> (Updated April 1, 2015, 7:40 p.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: MESOS-2462
> https://issues.apache.org/jira/browse/MESOS-2462
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used the argv version of subprocess for linux perf utilities. See discussion in MESOS-2462. This is to prepare for the death signal patch.
>
>
> Diffs
> -----
>
> src/linux/perf.cpp 863aa4a972289a59f57e93cd06ba2bf9df949fe2
>
> Diff: https://reviews.apache.org/r/32698/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 32698: Used the argv version of subprocess for
linux perf utilities.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32698/
-----------------------------------------------------------
(Updated April 1, 2015, 7:40 p.m.)
Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
Changes
-------
Review comments.
Bugs: MESOS-2462
https://issues.apache.org/jira/browse/MESOS-2462
Repository: mesos
Description
-------
Used the argv version of subprocess for linux perf utilities. See discussion in MESOS-2462. This is to prepare for the death signal patch.
Diffs (updated)
-----
src/linux/perf.cpp 863aa4a972289a59f57e93cd06ba2bf9df949fe2
Diff: https://reviews.apache.org/r/32698/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 32698: Used the argv version of subprocess for
linux perf utilities.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32698/
-----------------------------------------------------------
(Updated March 31, 2015, 8:04 p.m.)
Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
Bugs: MESOS-2462
https://issues.apache.org/jira/browse/MESOS-2462
Repository: mesos
Description
-------
Used the argv version of subprocess for linux perf utilities. See discussion in MESOS-2462. This is to prepare for the death signal patch.
Diffs
-----
src/linux/perf.cpp 863aa4a972289a59f57e93cd06ba2bf9df949fe2
Diff: https://reviews.apache.org/r/32698/diff/
Testing (updated)
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 32698: Used the argv version of subprocess for
linux perf utilities.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32698/
-----------------------------------------------------------
(Updated March 31, 2015, 8:01 p.m.)
Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
Bugs: MESOS-2462
https://issues.apache.org/jira/browse/MESOS-2462
Repository: mesos
Description
-------
Used the argv version of subprocess for linux perf utilities. See discussion in MESOS-2462. This is to prepare for the death signal patch.
Diffs
-----
src/linux/perf.cpp 863aa4a972289a59f57e93cd06ba2bf9df949fe2
Diff: https://reviews.apache.org/r/32698/diff/
Testing
-------
Thanks,
Jie Yu