[GitHub] [commons-vfs] XenoAmess commented on pull request #82: VFS-257 - FTP: Add support for MDTM to get more accurate last modified times

[GitBox <gi...@apache.org>]

XenoAmess commented on pull request #82:
URL: https://github.com/apache/commons-vfs/pull/82#issuecomment-642874368


   error details from travis-ci (java 11):
   ```
   Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.4 sec <<< FAILURE! - in org.apache.commons.vfs2.provider.sftp.test.SftpProviderClosedExecChannelTestCase
   junit.framework.TestSuite@58f437b0(org.apache.commons.vfs2.provider.sftp.test.SftpProviderClosedExecChannelTestCase$1)  Time elapsed: 0.4 sec  <<< ERROR!
   org.apache.commons.vfs2.FileSystemException: Could not determine the type of file "sftp://testtest@localhost:35683/read-tests".
   	at org.apache.commons.vfs2.provider.AbstractFileObject.getType(AbstractFileObject.java:1389)
   	at org.apache.commons.vfs2.provider.AbstractFileObject.exists(AbstractFileObject.java:967)
   	at org.apache.commons.vfs2.test.AbstractTestSuite.setUp(AbstractTestSuite.java:168)
   	at org.apache.commons.vfs2.provider.sftp.test.AbstractSftpProviderTestCase$SftpProviderTestSuite.setUp(AbstractSftpProviderTestCase.java:265)
   	at org.apache.commons.vfs2.test.AbstractTestSuite.lambda$run$0(AbstractTestSuite.java:129)
   	at junit.framework.TestResult.runProtected(TestResult.java:142)
   	at org.apache.commons.vfs2.test.AbstractTestSuite.run(AbstractTestSuite.java:134)
   	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:90)
   	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:367)
   	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:274)
   	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
   	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
   	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:290)
   	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:242)
   	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121)
   Caused by: org.apache.commons.vfs2.FileSystemException: Could not connect to SFTP server at "sftp://testtest@localhost:35683/".
   	at org.apache.commons.vfs2.provider.sftp.SftpFileSystem.getChannel(SftpFileSystem.java:164)
   	at org.apache.commons.vfs2.provider.sftp.SftpFileObject.statSelf(SftpFileObject.java:106)
   	at org.apache.commons.vfs2.provider.sftp.SftpFileObject.doGetType(SftpFileObject.java:76)
   	at org.apache.commons.vfs2.provider.AbstractFileObject.getType(AbstractFileObject.java:1383)
   	... 14 more
   Caused by: com.jcraft.jsch.JSchException: java.net.SocketException: Broken pipe (Write failed)
   	at com.jcraft.jsch.Channel.connect(Channel.java:159)
   	at org.apache.commons.vfs2.provider.sftp.SftpFileSystem.getChannel(SftpFileSystem.java:138)
   	... 17 more
   Caused by: java.net.SocketException: Broken pipe (Write failed)
   	at java.base/java.net.SocketOutputStream.socketWrite0(Native Method)
   	at java.base/java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:110)
   	at java.base/java.net.SocketOutputStream.write(SocketOutputStream.java:150)
   	at com.jcraft.jsch.IO.put(IO.java:60)
   	at com.jcraft.jsch.Session._write(Session.java:1379)
   	at com.jcraft.jsch.Session.write(Session.java:1372)
   	at com.jcraft.jsch.Channel.sendChannelOpen(Channel.java:732)
   	at com.jcraft.jsch.Channel.connect(Channel.java:151)
   	... 18 more
   ```
   
   And, since every commit of this pr excluding the last one have no such error, I agree with gary this time, you might merge what in master and test it again(or several times), to see if this bug still occurs, or it occurs evertime, or it occurs sometimes.
   
   The other commits fails on travis-ci only for openjdk-ea thing. ea is (or was) not compatible with one of a plugin we use (in commons-parent, so in nearly all commons project).  I put openjdk-ea in this repo into allow-failure at Feb 26, but this pr is when Feb 14, so...
   
   (Btw, thanks for gary & other cool guys the new version of that plugin has released, and which is compatible with openjdk-ea.)
   
   Anyway, I understand the frustration you felt when you see the red cross on travis-ci, and somethimes it just error/fail something with you do nothing wrong. Maybe a network error(in travis-ci, and makes it cannot download some dependencies), maybe a plugin not compatible, maybe another guy made a test that runs perfect in most times but will throw error when you are unlucky (this is real...especially for some memory-limit/gc related tests), and really, maybe it is not your fault for the tests fail.
   
   But it is still quite helpful, so we should always care about the output result, and try to find out why it failed. or at least, find out whether the failures be caused by this pr.
   Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org