You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by bouk <gi...@git.apache.org> on 2014/04/23 22:38:46 UTC
[GitHub] spark pull request: Let pyspark execute files even when IPYTHON=1
GitHub user bouk opened a pull request:
https://github.com/apache/spark/pull/515
Let pyspark execute files even when IPYTHON=1
With the release of IPython 2.0 having the `PYTHONSTARTUP` environment variable and passing a file at the same time works as expected. So, we can just pass the commandline args straight to IPython.
Also remove `IPYTHON_OPTS`, as you can now just pass options to IPython directly
This puts the behavior of `IPYTHON=1` in line with the regular Python interpreter
Note that this won't work correctly when IPython version < 2.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Shopify/spark ipython-parameters
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/515.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #515
----
commit 484f58660ad475bf8dfb08bff0ea08af9e7f7bdf
Author: Bouke van der Bijl <bo...@gmail.com>
Date: 2014-04-23T18:01:19Z
Let pyspark execute files even when IPYTHON=1
Also remove IPYTHON_OPTS
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Let pyspark execute files even when IPYTHON=1
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/515#issuecomment-41212085
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Let pyspark execute files even when IPYTHON=1
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/515#issuecomment-41212097
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Let pyspark execute files even when IPYTHON=1
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/515#issuecomment-41216418
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Let pyspark execute files even when IPYTHON=1
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/515
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Let pyspark execute files even when IPYTHON=1
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/515#issuecomment-50440531
If you can figure out a way to retain backwards-compatibility with IPython < 2, I'd be happy to merge this. Maybe you can do something like parsing `ipython --version` and change behavior based on that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Let pyspark execute files even when IPYTHON=1
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/515#issuecomment-41216419
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14393/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Let pyspark execute files even when IPYTHON=1
Posted by mateiz <gi...@git.apache.org>.
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/515#issuecomment-41223271
Because this won't work on IPython < 2, we unfortunately can't merge it. You should just file an issue in https://issues.apache.org/jira/browse/SPARK and we will revisit it when IPython 2 has much broader adoption. Unfortunately for a while lots of people will probably still be on 1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---