You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/09/26 22:28:59 UTC

[GitHub] newtonle commented on a change in pull request #3956: [AIRFLOW-3123] Use a stack for DAG context management

newtonle commented on a change in pull request #3956: [AIRFLOW-3123] Use a stack for DAG context management
URL: https://github.com/apache/incubator-airflow/pull/3956#discussion_r220743204
 
 

 ##########
 File path: airflow/models.py
 ##########
 @@ -3389,7 +3389,7 @@ def __init__(
         self.on_success_callback = on_success_callback
         self.on_failure_callback = on_failure_callback
 
-        self._context_manager_set = False
+        self._old_context_manager_dags = []
 
 Review comment:
   Actually this doesn't contain the current one. It just contains what was in `_CONTEXT_MANAGER_DAG` before it is set to the current DAG. The `old` naming convention was existing, and the only difference here is making into a list.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services