[GitHub] [servicecomb-java-chassis] doom15 commented on issue #3404: IsolationDiscoveryFilter配置项不兼容，且不支持微服务级别的开关

[GitBox <gi...@apache.org>]

doom15 commented on issue #3404:
URL: https://github.com/apache/servicecomb-java-chassis/issues/3404#issuecomment-1285106911

    是1.3.7升级到1.3.8版本的[IsolationDiscoveryFilter.java](https://github.com/apache/servicecomb-java-chassis/commit/61e2db26f9a29f5b4e55ff7604f8771ac7f09728#diff-e6ac82e6fe140a22ad99f21f3c6d8baa24da0ffb156f95be6cb3b1bd28072f3a)，在1.3.7版本是用：
   ```
       if (!Configuration.INSTANCE.isIsolationFilterOpen(invocation.getMicroserviceName())) {
         return parent;
       }
   ```
   对应的代码如下：
   ```
     public boolean isIsolationFilterOpen(String microservice) {
       String p = getStringProperty("true",
           PROP_ROOT + microservice + "." + FILTER_ISOLATION + FILTER_OPEN,
           PROP_ROOT + FILTER_ISOLATION + FILTER_OPEN);
       return Boolean.parseBoolean(p);
     }
   ```
   
   1.3.8之后就改为了filter的enable方法了，原来的配置项失效了，且不支持微服务
   ```
     @Override
     public boolean enabled() {
       return DynamicPropertyFactory.getInstance()
           .getBooleanProperty("servicecomb.loadbalance.filter.isolation.enabled", true).get();
     }
   ```
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org