You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/17 09:38:32 UTC

[GitHub] [arrow] rouault commented on pull request #13164: [C++] cpp/parquet/Statistics: clarify that num_values() is the number of non-null values

rouault commented on PR #13164:
URL: https://github.com/apache/arrow/pull/13164#issuecomment-1128647690

   > IMO we can keep it.
   
   The change of name of the private member is to be consistent with the ``num_not_null`` argument of TypedStatisticsImpl::Update at https://github.com/apache/arrow/blob/52a051b1f01669647d8f4d16d7de30c10265dc51/cpp/src/parquet/statistics.cc#L565, which is how I realized what the semantics of num_values() was


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org