You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Randy Terbush <ra...@zyzzyva.com> on 1997/01/15 08:25:06 UTC
lingering_close() one problem solved?
I've been running the following change for nearly 2 hours now
and have not noticed any problems. In fact, I have not logged
a single 'shutdown: Invalid argument OR lingering_close'
since applying the change. A snippet of one of my logs shows
what was going on earlier today.
RCS file: /export/home/cvs/apache/src/http_main.c,v
retrieving revision 1.105
diff -c -r1.105 http_main.c
*** http_main.c 1997/01/10 18:47:36 1.105
--- http_main.c 1997/01/15 07:20:14
***************
*** 1669,1676 ****
#ifdef NO_LINGCLOSE
bclose(conn_io); /* just close it */
#else
! if (r)
lingering_close (conn_io->fd, r->server);
else
close (conn_io->fd);
#endif
--- 1669,1678 ----
#ifdef NO_LINGCLOSE
bclose(conn_io); /* just close it */
#else
! if (r) {
! kill_timeout(r);
lingering_close (conn_io->fd, r->server);
+ }
else
close (conn_io->fd);
#endif
[Tue Jan 14 00:58:14 1997] shutdown: Invalid argument
[Tue Jan 14 00:58:14 1997] - lingering_close
[Tue Jan 14 00:59:41 1997] shutdown: Invalid argument
[Tue Jan 14 00:59:41 1997] - lingering_close
[Tue Jan 14 01:08:14 1997] shutdown: Invalid argument
[Tue Jan 14 01:08:14 1997] - lingering_close
[Tue Jan 14 01:11:18 1997] shutdown: Invalid argument
[Tue Jan 14 01:11:18 1997] - lingering_close
[Tue Jan 14 01:12:49 1997] shutdown: Invalid argument
[Tue Jan 14 01:12:49 1997] - lingering_close
[Tue Jan 14 01:13:25 1997] shutdown: Invalid argument
[Tue Jan 14 01:13:25 1997] - lingering_close
[Tue Jan 14 01:13:51 1997] shutdown: Invalid argument
[Tue Jan 14 01:13:51 1997] - lingering_close
[Tue Jan 14 01:15:11 1997] shutdown: Invalid argument
[Tue Jan 14 01:15:11 1997] - lingering_close
[Tue Jan 14 01:16:14 1997] shutdown: Invalid argument
[Tue Jan 14 01:16:14 1997] - lingering_close
[Tue Jan 14 01:17:09 1997] shutdown: Invalid argument
[Tue Jan 14 01:17:09 1997] - lingering_close
[Tue Jan 14 01:17:54 1997] shutdown: Invalid argument
[Tue Jan 14 01:17:54 1997] - lingering_close
[Tue Jan 14 01:18:40 1997] shutdown: Invalid argument
[Tue Jan 14 01:18:40 1997] - lingering_close
[Tue Jan 14 01:19:25 1997] shutdown: Invalid argument
[Tue Jan 14 01:19:25 1997] - lingering_close
[Tue Jan 14 01:20:10 1997] shutdown: Invalid argument
[Tue Jan 14 01:20:10 1997] - lingering_close
[Tue Jan 14 01:20:52 1997] shutdown: Invalid argument
[Tue Jan 14 01:20:52 1997] - lingering_close
Re: lingering_close() one problem solved?
Posted by Rob Hartill <ro...@imdb.com>.
On Wed, 15 Jan 1997, Randy Terbush wrote:
> I've been running the following change for nearly 2 hours now
> and have not noticed any problems. In fact, I have not logged
> a single 'shutdown: Invalid argument OR lingering_close'
> since applying the change.
Interesting. Does the "kill_timeout" need to be applied inside
the #ifdef NO_LINGCLOSE block too (with an if (r) ) ?
> RCS file: /export/home/cvs/apache/src/http_main.c,v
> retrieving revision 1.105
> diff -c -r1.105 http_main.c
> *** http_main.c 1997/01/10 18:47:36 1.105
> --- http_main.c 1997/01/15 07:20:14
> ***************
> *** 1669,1676 ****
> #ifdef NO_LINGCLOSE
> bclose(conn_io); /* just close it */
> #else
> ! if (r)
> lingering_close (conn_io->fd, r->server);
> else
> close (conn_io->fd);
> #endif
> --- 1669,1678 ----
> #ifdef NO_LINGCLOSE
> bclose(conn_io); /* just close it */
> #else
> ! if (r) {
> ! kill_timeout(r);
> lingering_close (conn_io->fd, r->server);
> + }
> else
> close (conn_io->fd);
> #endif