You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/01/17 18:24:30 UTC
[I] Deprecate `datafusion.execution.parquet.max_statistics_size` config option [datafusion]
alamb opened a new issue, #14172:
URL: https://github.com/apache/datafusion/issues/14172
### Is your feature request related to a problem or challenge?
The most recent version of arrow deprecates the `max_statistics_size` parquet option
- https://github.com/apache/datafusion/pull/14153/
You can see the rationale from @etseidl here (it was being silently ignored)
- https://github.com/apache/arrow-rs/pull/6884
DataFusion also exposes this setting:
https://datafusion.apache.org/user-guide/configs.html
datafusion.execution.parquet.max_statistics_size | 4096 | (writing) Sets max statistics size for any column. If NULL, uses default parquet writer setting
-- | -- | --
We should deprecate it as well prior to removal
### Describe the solution you'd like
1. Mark the option deprecated in comments
2. Make the field deprecated in the code
The config option is defined in two places:
https://github.com/apache/datafusion/blob/04b6d4d6099f537de91e1b30a391bdfbc3ec36d5/datafusion/common/src/config.rs#L1723-L1722
https://github.com/apache/datafusion/blob/04b6d4d6099f537de91e1b30a391bdfbc3ec36d5/datafusion/common/src/config.rs#L1723-L1722
But I think they are done via macro
### Describe alternatives you've considered
We can just wait until the field is removed upstream in arrow and yank it from datafusion too
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Deprecate `datafusion.execution.parquet.max_statistics_size` config option [datafusion]
Posted by "logan-keede (via GitHub)" <gi...@apache.org>.
logan-keede commented on issue #14172:
URL: https://github.com/apache/datafusion/issues/14172#issuecomment-2599235975
Hi @alamb, Please check if my PR #14175 correctly addresses this issue
Thanks,
Logan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Deprecate `datafusion.execution.parquet.max_statistics_size` config option [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #14172: Deprecate `datafusion.execution.parquet.max_statistics_size` config option
URL: https://github.com/apache/datafusion/issues/14172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org