You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "lawofcycles (via GitHub)" <gi...@apache.org> on 2024/04/07 04:10:59 UTC
[PR] Docs: Fix On-screen display issues and minor expressions on Branching and Tagging DDL [iceberg]
lawofcycles opened a new pull request, #10091:
URL: https://github.com/apache/iceberg/pull/10091
I propose following three modifications.
- Fix a broken bullet point display.
<img width="785" alt="Screenshot 2024-04-07 at 13 05 49" src="https://github.com/apache/iceberg/assets/70102274/1ce9bfe1-4424-4b59-baec-ccf7e6a3fec7">
<img width="783" alt="Screenshot 2024-04-07 at 13 05 56" src="https://github.com/apache/iceberg/assets/70102274/1e6e4e9a-7ecb-43df-9536-a682a7226096">
- Fix inconsistency between comment and SQL
> -- CREATE audit-branch at snapshot 1234, retain audit-branch for 31 days, and retain the latest 31 days. The latest 3
> snapshot snapshots, and 2 days worth of snapshots.
> ALTER TABLE prod.db.sample CREATE BRANCH `audit-branch`
> AS OF VERSION 1234 RETAIN 30 DAYS
> WITH SNAPSHOT RETENTION 3 SNAPSHOTS 2 DAYS
- A little clearer explanation of the respective options for DDLs.
I would be happy for you to review my proposal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Fix On-screen display issues and minor expressions on Branching and Tagging DDL [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #10091:
URL: https://github.com/apache/iceberg/pull/10091#discussion_r1555345466
##########
docs/docs/spark-ddl.md:
##########
@@ -499,17 +500,18 @@ AS OF VERSION 1234
-- CREATE audit-branch at snapshot 1234, retain audit-branch for 31 days, and retain the latest 31 days. The latest 3 snapshot snapshots, and 2 days worth of snapshots.
ALTER TABLE prod.db.sample CREATE BRANCH `audit-branch`
-AS OF VERSION 1234 RETAIN 30 DAYS
+AS OF VERSION 1234 RETAIN 31 DAYS
Review Comment:
rather than changing it here, can you please change it in the description above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Fix On-screen display issues and minor expressions on Branching and Tagging DDL [iceberg]
Posted by "lawofcycles (via GitHub)" <gi...@apache.org>.
lawofcycles commented on code in PR #10091:
URL: https://github.com/apache/iceberg/pull/10091#discussion_r1556378194
##########
docs/docs/spark-ddl.md:
##########
@@ -499,17 +500,18 @@ AS OF VERSION 1234
-- CREATE audit-branch at snapshot 1234, retain audit-branch for 31 days, and retain the latest 31 days. The latest 3 snapshot snapshots, and 2 days worth of snapshots.
ALTER TABLE prod.db.sample CREATE BRANCH `audit-branch`
-AS OF VERSION 1234 RETAIN 30 DAYS
+AS OF VERSION 1234 RETAIN 31 DAYS
Review Comment:
I've updated the description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Fix On-screen display issues and minor expressions on Branching and Tagging DDL [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #10091:
URL: https://github.com/apache/iceberg/pull/10091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org