[GitHub] [arrow] raulcd commented on a diff in pull request #14247: ARROW-17854: [CI][Developer] Hoste preview docs on S3

[GitBox <gi...@apache.org>]

raulcd commented on code in PR #14247:
URL: https://github.com/apache/arrow/pull/14247#discussion_r981443050


##########
dev/tasks/docs/github.linux.yml:
##########
@@ -44,23 +44,18 @@ jobs:
           ref: {{ default_branch|default("master") }}
           path: crossbow
           fetch-depth: 1
-      - name: Move docs
+      - name: Prepare docs
         run: |
           # build files are created by the docker user
           sudo chown -R ${USER}: build
-          PR_DIR=crossbow/docs/pr_docs/{{ pr_number }}
-          mkdir -p $PR_DIR
-          rsync -a --delete build/docs/ $PR_DIR
-      - name: Push changes
+          # These are only used while generating the page
+          rm -rf build/docs/.doctrees
+      - name: Upload preview to S3
+        env: 
+          AWS_ACCESS_KEY_ID: {{ '${{ secrets.CROSSBOW_DOCS_AWS_ACCESS_KEY_ID }}' }}

Review Comment:
   I am probably missing something but wouldn't the following work?
   ```suggestion
             AWS_ACCESS_KEY_ID: ${{ secrets.CROSSBOW_DOCS_AWS_ACCESS_KEY_ID }}
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org