[GitHub] [incubator-pinot] sunithabeeram commented on issue #4197: Add SimpleAvroMessageDecoder which allows passing in Avro schema directly

[GitBox <gi...@apache.org>]

sunithabeeram commented on issue #4197: Add SimpleAvroMessageDecoder which allows passing in Avro schema directly
URL: https://github.com/apache/incubator-pinot/pull/4197#issuecomment-492325057
 
 
   A few thoughts on this:
   - Have we considered updating KafkaAvroMessageDecoder to work with this case? I do see that class being tied up quite a bit with schema registry, but I don't see why that can't be made cleaner and able to handle the case this class tries to.
   - This is more of a comment on KafkaAvroMessageDecoder, but I guess we could reuse the GenericDatumReader there unless the schema has changed (which should be rare and we can avoid the extra object allocation on each decode)
   - Depending on how important this particular implementation is, it will be good to add a test to guard against regressions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org