You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Hadrian Zbarcea (JIRA)" <ji...@apache.org> on 2008/04/24 22:32:43 UTC
[jira] Created: (CAMEL-481) Interceptors to proceed by default
Interceptors to proceed by default
----------------------------------
Key: CAMEL-481
URL: https://issues.apache.org/activemq/browse/CAMEL-481
Project: Apache Camel
Issue Type: Improvement
Components: camel-core
Affects Versions: 1.3.0
Reporter: Hadrian Zbarcea
Assignee: Hadrian Zbarcea
Fix For: 1.4.0
intercept().to(...) should proceed by default, without and explicit .proceed(). To stop processing after intercept use the following syntax:
intercept(false).to(intercept-endpoint)
View nabble thread:
http://www.nabble.com/interceptors---something-is-terrible-wrong-td16661322s22882.html#a16661322
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-481) Interceptors to proceed by default
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43725#action_43725 ]
Hadrian Zbarcea commented on CAMEL-481:
---------------------------------------
I think I'll be done with this today. There is only one issue planned for 1.4 and then I'll cut the kit.
> Interceptors to proceed by default
> ----------------------------------
>
> Key: CAMEL-481
> URL: https://issues.apache.org/activemq/browse/CAMEL-481
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Hadrian Zbarcea
> Assignee: Hadrian Zbarcea
> Fix For: 1.5.0
>
>
> intercept().to(...) should proceed by default, without and explicit .proceed(). To stop processing after intercept use the following syntax:
> intercept(false).to(intercept-endpoint)
> View nabble thread:
> http://www.nabble.com/interceptors---something-is-terrible-wrong-td16661322s22882.html#a16661322
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-481) Interceptors to proceed by default
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43580#action_43580 ]
Claus Ibsen commented on CAMEL-481:
-----------------------------------
+1 on what is intuitive.
But the intercept() has been documented in the wiki that it's like a AOP logger. That it can be used to track "what is going on".
But nevertheless James has added some new debug feature that might be used for such scenarios.
We could enhance the debug feature or something similar for the "AOP logger" feature. It is rather useful on a more low-level basis to track how message exchanges is flying around in Camel ;)
> Interceptors to proceed by default
> ----------------------------------
>
> Key: CAMEL-481
> URL: https://issues.apache.org/activemq/browse/CAMEL-481
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Hadrian Zbarcea
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
>
> intercept().to(...) should proceed by default, without and explicit .proceed(). To stop processing after intercept use the following syntax:
> intercept(false).to(intercept-endpoint)
> View nabble thread:
> http://www.nabble.com/interceptors---something-is-terrible-wrong-td16661322s22882.html#a16661322
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-481) Interceptors to proceed by default
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-481:
------------------------------
Fix Version/s: 1.5.0
(was: 1.4.0)
Affects Version/s: 1.4.0
> Interceptors to proceed by default
> ----------------------------------
>
> Key: CAMEL-481
> URL: https://issues.apache.org/activemq/browse/CAMEL-481
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Hadrian Zbarcea
> Assignee: Hadrian Zbarcea
> Fix For: 1.5.0
>
>
> intercept().to(...) should proceed by default, without and explicit .proceed(). To stop processing after intercept use the following syntax:
> intercept(false).to(intercept-endpoint)
> View nabble thread:
> http://www.nabble.com/interceptors---something-is-terrible-wrong-td16661322s22882.html#a16661322
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-481) Interceptors to proceed by default
Posted by "Jonathan Anstey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43737#action_43737 ]
Jonathan Anstey commented on CAMEL-481:
---------------------------------------
Sorry for the extra work man :) Thanks!
> Interceptors to proceed by default
> ----------------------------------
>
> Key: CAMEL-481
> URL: https://issues.apache.org/activemq/browse/CAMEL-481
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Hadrian Zbarcea
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: fix-aix-compile-issue.patch
>
>
> intercept().to(...) should proceed by default, without and explicit .proceed(). To stop processing after intercept use the following syntax:
> intercept(false).to(intercept-endpoint)
> View nabble thread:
> http://www.nabble.com/interceptors---something-is-terrible-wrong-td16661322s22882.html#a16661322
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-481) Interceptors to proceed by default
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43571#action_43571 ]
Hadrian Zbarcea commented on CAMEL-481:
---------------------------------------
I think my proposal above is not very good because of the intercept(Predicate predicate) flavor. I think a stop() would be more appropriate.
One more aspect. In the following scenario, what would be the expected default behavior assuming an implicit proceed?
{code}
intercept(header("foo").isEqualTo("bar")).to("mock:b");
from("direct:start").to("mock:a");
{code}
Clearly the "mock:b" endpoint will only receive the message if header("foo") equals "bar", but what about "mock:a", should it be invoked anyway, or only if the predicate didn't fire? My mild preference would be to only invoke "mock:a" if the predicate did not fire.
> Interceptors to proceed by default
> ----------------------------------
>
> Key: CAMEL-481
> URL: https://issues.apache.org/activemq/browse/CAMEL-481
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Hadrian Zbarcea
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
>
> intercept().to(...) should proceed by default, without and explicit .proceed(). To stop processing after intercept use the following syntax:
> intercept(false).to(intercept-endpoint)
> View nabble thread:
> http://www.nabble.com/interceptors---something-is-terrible-wrong-td16661322s22882.html#a16661322
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-481) Interceptors to proceed by default
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43710#action_43710 ]
Claus Ibsen commented on CAMEL-481:
-----------------------------------
Hadrian, I have scheduled this for 1.5, hope you don't mind ;)
Would be good to have a clear path and be able to cut a new RC for 1.4 this week.
> Interceptors to proceed by default
> ----------------------------------
>
> Key: CAMEL-481
> URL: https://issues.apache.org/activemq/browse/CAMEL-481
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Hadrian Zbarcea
> Assignee: Hadrian Zbarcea
> Fix For: 1.5.0
>
>
> intercept().to(...) should proceed by default, without and explicit .proceed(). To stop processing after intercept use the following syntax:
> intercept(false).to(intercept-endpoint)
> View nabble thread:
> http://www.nabble.com/interceptors---something-is-terrible-wrong-td16661322s22882.html#a16661322
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-481) Interceptors to proceed by default
Posted by "Jonathan Anstey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Anstey updated CAMEL-481:
----------------------------------
Attachment: fix-aix-compile-issue.patch
Hadrian,
Just noticed the fix for this issue fails to compile on AIX. I'm attaching a fix for this.
Cheers,
Jon
> Interceptors to proceed by default
> ----------------------------------
>
> Key: CAMEL-481
> URL: https://issues.apache.org/activemq/browse/CAMEL-481
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Hadrian Zbarcea
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: fix-aix-compile-issue.patch
>
>
> intercept().to(...) should proceed by default, without and explicit .proceed(). To stop processing after intercept use the following syntax:
> intercept(false).to(intercept-endpoint)
> View nabble thread:
> http://www.nabble.com/interceptors---something-is-terrible-wrong-td16661322s22882.html#a16661322
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-481) Interceptors to proceed by default
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hadrian Zbarcea resolved CAMEL-481.
-----------------------------------
Fix Version/s: 1.4.0
(was: 1.5.0)
Resolution: Fixed
> Interceptors to proceed by default
> ----------------------------------
>
> Key: CAMEL-481
> URL: https://issues.apache.org/activemq/browse/CAMEL-481
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Hadrian Zbarcea
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
>
> intercept().to(...) should proceed by default, without and explicit .proceed(). To stop processing after intercept use the following syntax:
> intercept(false).to(intercept-endpoint)
> View nabble thread:
> http://www.nabble.com/interceptors---something-is-terrible-wrong-td16661322s22882.html#a16661322
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-481) Interceptors to proceed by default
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42442#action_42442 ]
Claus Ibsen commented on CAMEL-481:
-----------------------------------
Remember to update the wiki at:
http://activemq.apache.org/camel/dsl.html
> Interceptors to proceed by default
> ----------------------------------
>
> Key: CAMEL-481
> URL: https://issues.apache.org/activemq/browse/CAMEL-481
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Hadrian Zbarcea
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
>
> intercept().to(...) should proceed by default, without and explicit .proceed(). To stop processing after intercept use the following syntax:
> intercept(false).to(intercept-endpoint)
> View nabble thread:
> http://www.nabble.com/interceptors---something-is-terrible-wrong-td16661322s22882.html#a16661322
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-481) Interceptors to proceed by default
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43736#action_43736 ]
Hadrian Zbarcea commented on CAMEL-481:
---------------------------------------
Patch applied with thanks! I redid the 1.4.0 kit just for this :)
> Interceptors to proceed by default
> ----------------------------------
>
> Key: CAMEL-481
> URL: https://issues.apache.org/activemq/browse/CAMEL-481
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Hadrian Zbarcea
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: fix-aix-compile-issue.patch
>
>
> intercept().to(...) should proceed by default, without and explicit .proceed(). To stop processing after intercept use the following syntax:
> intercept(false).to(intercept-endpoint)
> View nabble thread:
> http://www.nabble.com/interceptors---something-is-terrible-wrong-td16661322s22882.html#a16661322
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-481) Interceptors to proceed by default
Posted by "Jonathan Anstey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43579#action_43579 ]
Jonathan Anstey commented on CAMEL-481:
---------------------------------------
{quote}
My mild preference would be to only invoke "mock:a" if the predicate did not fire.
{quote}
This is intuitive. I like it :)
> Interceptors to proceed by default
> ----------------------------------
>
> Key: CAMEL-481
> URL: https://issues.apache.org/activemq/browse/CAMEL-481
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Hadrian Zbarcea
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
>
> intercept().to(...) should proceed by default, without and explicit .proceed(). To stop processing after intercept use the following syntax:
> intercept(false).to(intercept-endpoint)
> View nabble thread:
> http://www.nabble.com/interceptors---something-is-terrible-wrong-td16661322s22882.html#a16661322
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.