You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2023/01/10 04:37:20 UTC
[GitHub] [incubator-pegasus] acelyc111 opened a new issue, #1305: Refactor log macros
acelyc111 opened a new issue, #1305:
URL: https://github.com/apache/incubator-pegasus/issues/1305
There are two type of log macros in the code, one is using C string format specifiers, like `LOG_INFO`, the other is using `libfmt`, like `LOG_INFO_F`.
It's strange to keep the two macros in long term, I'm planning to refactor them and only leave `libfmt` style one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on issue #1305: Refactor log macros
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on issue #1305:
URL: https://github.com/apache/incubator-pegasus/issues/1305#issuecomment-1377327350
> After all `LOG_*` macros have been replaced with `LOG_*_F`, would `LOG_*_F` be renamed as `LOG_*`? For example, `LOG_INFO_F` is renamed as `LOG_INFO` ?
Yes, I'm planning to still use `LOG_*_F` before all refactor work been finished, then remove `_F` postfix at last in one patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on issue #1305: Refactor log macros
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on issue #1305:
URL: https://github.com/apache/incubator-pegasus/issues/1305#issuecomment-1376730371
Because there are so many code to be modified, I'll separet the whole work into smaller patches to make reviewers happy 😆
- LOG_DEBUG
- all
- LOG_INFO
- replica module
- meta module
- others
- LOG_WARN
- replica module
- meta module
- others
- LOG_WARN
- replica module
- others
- LOG_FATAL
- all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan commented on issue #1305: Refactor log macros
Posted by GitBox <gi...@apache.org>.
empiredan commented on issue #1305:
URL: https://github.com/apache/incubator-pegasus/issues/1305#issuecomment-1377437413
> > > After all `LOG_*` macros have been replaced with `LOG_*_F`, would `LOG_*_F` be renamed as `LOG_*`? For example, `LOG_INFO_F` is renamed as `LOG_INFO` ?
> >
> >
> > Yes, I'm planning to still use `LOG_*_F` before all refactor work been finished, then remove `_F` postfix at last in one patch.
>
> In this way, all macros with or without `_F` postfix are both in the same semantics in the progress.
I think it is important to keep all macros consistent without intermediate stages. Let's go ahead !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on issue #1305: Refactor log macros
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on issue #1305:
URL: https://github.com/apache/incubator-pegasus/issues/1305#issuecomment-1383576451
> Meticulous work! Can we add some checking of parameter count in the log function? ref: [fmtlib/fmt#2593](https://github.com/fmtlib/fmt/issues/2593)
I assigned this work to you, you can implement it if you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on issue #1305: Refactor log macros
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on issue #1305:
URL: https://github.com/apache/incubator-pegasus/issues/1305#issuecomment-1383595540
@GehaFearless Could you please to do the remain work?
LOG_WARN
- replica module
- meta module
- others
LOG_ERROR
- replica module
- others
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Smityz commented on issue #1305: Refactor log macros
Posted by GitBox <gi...@apache.org>.
Smityz commented on issue #1305:
URL: https://github.com/apache/incubator-pegasus/issues/1305#issuecomment-1382830909
Meticulous work!
Can we add some checking of parameter count in the log function?
ref: https://github.com/fmtlib/fmt/issues/2593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan commented on issue #1305: Refactor log macros
Posted by GitBox <gi...@apache.org>.
empiredan commented on issue #1305:
URL: https://github.com/apache/incubator-pegasus/issues/1305#issuecomment-1377185062
After all `LOG_*` macros have been replaced with `LOG_*_F`, would `LOG_*_F` be renamed as `LOG_*`? For example, `LOG_INFO_F` is renamed as `LOG_INFO` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on issue #1305: Refactor log macros
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on issue #1305:
URL: https://github.com/apache/incubator-pegasus/issues/1305#issuecomment-1377351746
> > After all `LOG_*` macros have been replaced with `LOG_*_F`, would `LOG_*_F` be renamed as `LOG_*`? For example, `LOG_INFO_F` is renamed as `LOG_INFO` ?
>
> Yes, I'm planning to still use `LOG_*_F` before all refactor work been finished, then remove `_F` postfix at last in one patch.
In this way, all macros with or without `_F` postfix are both in the same semantics in the progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on issue #1305: Refactor log macros
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on issue #1305:
URL: https://github.com/apache/incubator-pegasus/issues/1305#issuecomment-1377326766
Yes, I'm planning to still use `LOG_*_F` before all refactor work been finished, then remove `_F` postfix at last in one patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 closed issue #1305: Refactor log macros
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 closed issue #1305: Refactor log macros
URL: https://github.com/apache/incubator-pegasus/issues/1305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org