You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "123123213weqw (via GitHub)" <gi...@apache.org> on 2026/09/30 13:40:28 UTC
[PR] fix(web): localize the home dashboard failure alert and the footer version line [rocketmq-dashboard]
123123213weqw opened a new pull request, #5236:
URL: https://github.com/apache/rocketmq-dashboard/pull/5236
### Which Issue(s) This PR Fixes
Fixes #5224
### Brief Description
The load-failure Alert hardcoded its message, description and retry label although the page already holds `t` and `common.retry` exists, and the home footer rendered 当前版本 raw next to localized neighbours. Both now resolve through the translation table (`homeDashboard.*`, `home.currentVersion` with build-metadata interpolation).
### How Did You Test This Change
`npx vitest run src/pages/home/__tests__/` — 16/16 green, including a test that fails the dashboard load in the English locale and pins the alert strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): localize the home dashboard failure alert and the footer version line [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #5236:
URL: https://github.com/apache/rocketmq-dashboard/pull/5236#issuecomment-6074068069
This pull request was closed by the stale bot on 2026-10-08 (seven days without activity), not by a maintainer decision - the review below is what we had queued for it.
The four hardcoded strings are real (`dashboard.tsx:168-172` and `index.tsx:505`) and there is no hook-dependency problem in the change. But `dashboard.tsx` and `index.tsx` on this branch are byte-identical to the same two files in #5329 (by @btlqql), so only one of the two can land; we will take one of them and say which on the other.
What we would have asked you to fix regardless:
1. The footer version line has no assertion. Add one inside the `describe('HomePage footer')` block of `HomePage.test.tsx` - under the en locale, `getByText(/Current version .* build\(/)` plus an assertion that 当前版本 is absent - otherwise the `index.tsx:505` half of this change can be reverted without reddening anything.
2. The description claims 16/16 cases; please reconcile it to what a single run on the current base actually yields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): localize the home dashboard failure alert and the footer version line [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5236:
URL: https://github.com/apache/rocketmq-dashboard/pull/5236#issuecomment-6049500445
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): localize the home dashboard failure alert and the footer version line [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5236: fix(web): localize the home dashboard failure alert and the footer version line
URL: https://github.com/apache/rocketmq-dashboard/pull/5236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org