[jira] [Commented] (MINIFI-350) Create integration tests for cpp docker image

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFI-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153659#comment-16153659 ] 

ASF GitHub Bot commented on MINIFI-350:
---------------------------------------

Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/126#discussion_r136992525
  
    --- Diff: README.md ---
    @@ -124,6 +133,8 @@ $ brew install cmake \
       doxygen
     $ brew install curl
     $ brew link curl --force
    +$ # (Optional) for building docker image/running system integration tests
    +$ # Install docker using instructions at https://docs.docker.com/docker-for-mac/install/
    --- End diff --
    
    Fixed. Added instruction to pip install virtualenv.


> Create integration tests for cpp docker image
> ---------------------------------------------
>
>                 Key: MINIFI-350
>                 URL: https://issues.apache.org/jira/browse/MINIFI-350
>             Project: Apache NiFi MiNiFi
>          Issue Type: Bug
>          Components: C++
>            Reporter: Andrew Christianson
>            Assignee: Andrew Christianson
>
> Create a unit test suite which uses compose or docker commands to set up minifi using the docker image and send data through test flows. Consider looking into existing test frameworks/harnesses.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)