You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "vy (via GitHub)" <gi...@apache.org> on 2025/01/15 14:41:16 UTC
[PR] Fix loading of the effective `RecyclerFactoryConverter` (logging-log4j2)
vy opened a new pull request, #3398:
URL: https://github.com/apache/logging-log4j2/pull/3398
Fixes #3395.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix loading of the effective `RecyclerFactoryConverter` (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #3398:
URL: https://github.com/apache/logging-log4j2/pull/3398#issuecomment-2615305736
@vy, could you port it to `main` or add it to the backlog (#3161)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix loading of the effective `RecyclerFactoryConverter` (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on PR #3398:
URL: https://github.com/apache/logging-log4j2/pull/3398#issuecomment-2615423141
> @vy, could you port it to `main` or add it to the backlog (#3161)?
Recyclers are wired in a totally different way in `main` (they are in `log4j-kit`, wired using `ServiceLoader`s, etc. I don't think this PR makes sense there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix loading of the effective `RecyclerFactoryConverter` (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on PR #3398:
URL: https://github.com/apache/logging-log4j2/pull/3398#issuecomment-2612231112
> So you eliminated the `RecyclerFactories` static registry and reused the type converter registry? Can you mark `RecyclerFactories` as deprecated?
Good catch. Fixed in 6f216f91cc1ad0c27fbb993e93feeb2ca6c043d3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix loading of the effective `RecyclerFactoryConverter` (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy merged PR #3398:
URL: https://github.com/apache/logging-log4j2/pull/3398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org