You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/27 09:41:10 UTC
[GitHub] [hudi] danny0405 opened a new pull request, #5703: [HUDI-4163] Catch general exception instead of IOException while fetc…
danny0405 opened a new pull request, #5703:
URL: https://github.com/apache/hudi/pull/5703
…hing rollback plan during rollback
If the avro file is corrupted, an InvalidAvroMagicException throws.
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #5703: [HUDI-4163] Catch general exception instead of IOException while fetc…
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on code in PR #5703:
URL: https://github.com/apache/hudi/pull/5703#discussion_r969646947
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1118,7 +1118,7 @@ protected Map<String, Option<HoodiePendingRollbackInfo>> getPendingRollbackInfos
HoodieRollbackPlan rollbackPlan;
try {
rollbackPlan = RollbackUtils.getRollbackPlan(metaClient, rollbackInstant);
- } catch (IOException e) {
+ } catch (Exception e) {
Review Comment:
@danny0405 : may I know why this fix was required? If we had exception like timeout or something else, probably we should not process it. we have the code within catch block only to handle corrupt files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5703: [HUDI-4163] Catch general exception instead of IOException while fetc…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5703:
URL: https://github.com/apache/hudi/pull/5703#issuecomment-1139471036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1068bcd7e69c457ef5f86f19ba22b58347f63cd1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8972",
"triggerID" : "1068bcd7e69c457ef5f86f19ba22b58347f63cd1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1068bcd7e69c457ef5f86f19ba22b58347f63cd1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8972)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5703: [HUDI-4163] Catch general exception instead of IOException while fetc…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5703:
URL: https://github.com/apache/hudi/pull/5703#issuecomment-1139468241
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1068bcd7e69c457ef5f86f19ba22b58347f63cd1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1068bcd7e69c457ef5f86f19ba22b58347f63cd1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1068bcd7e69c457ef5f86f19ba22b58347f63cd1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #5703: [HUDI-4163] Catch general exception instead of IOException while fetc…
Posted by GitBox <gi...@apache.org>.
danny0405 merged PR #5703:
URL: https://github.com/apache/hudi/pull/5703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5703: [HUDI-4163] Catch general exception instead of IOException while fetc…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5703:
URL: https://github.com/apache/hudi/pull/5703#issuecomment-1139642888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1068bcd7e69c457ef5f86f19ba22b58347f63cd1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8972",
"triggerID" : "1068bcd7e69c457ef5f86f19ba22b58347f63cd1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1068bcd7e69c457ef5f86f19ba22b58347f63cd1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8972)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org