You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/23 06:13:54 UTC
[GitHub] [incubator-seatunnel] zixi0825 opened a new pull request #1143: [Feature #1127][Plugin]Add Spark Ignite Source
zixi0825 opened a new pull request #1143:
URL: https://github.com/apache/incubator-seatunnel/pull/1143
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[SeaTunnel #XXXX] [component] Title of the pull request", where *SeaTunnel #XXXX* should be replaced by the actual issue number.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
This pull request adds spark ignite source. #1127
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in you PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zixi0825 commented on pull request #1143: [Feature] [connector] Add Spark Ignite Source
Posted by GitBox <gi...@apache.org>.
zixi0825 commented on pull request #1143:
URL: https://github.com/apache/incubator-seatunnel/pull/1143#issuecomment-1062544997
@CalvinKirs please reopen it ,thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on a change in pull request #1143: [Feature #1127][Plugin]Add Spark Ignite Source
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on a change in pull request #1143:
URL: https://github.com/apache/incubator-seatunnel/pull/1143#discussion_r791237361
##########
File path: docs/en/spark/configuration/source-plugins/Ignite.md
##########
@@ -0,0 +1,41 @@
+# Source plugin: Ignite
+
+### Description
+
+Read data from Ignite.
+
+### Options
+
+| name | type | required | default value |
+| -------------- | ------ | -------- | ------------- |
+| [table](#table-string) | string | yes | - |
+| [config.file.path](#config.file.path-string) | string | yes | - |
+
Review comment:
If I remember correctly `result_table_name` seems to be required, please check, thanks
##########
File path: seatunnel-connectors/seatunnel-connector-spark-ignite/pom.xml
##########
@@ -0,0 +1,56 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>seatunnel-connectors</artifactId>
+ <groupId>org.apache.seatunnel</groupId>
+ <version>2.0.5-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>seatunnel-connector-spark-ignite</artifactId>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-api-spark</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.ignite</groupId>
+ <artifactId>ignite-spark-2.4</artifactId>
+ </dependency>
Review comment:
Please define this version number in parent `pom.xml` , thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] SteNicholas commented on a change in pull request #1143: [Feature #1127][Plugin]Add Spark Ignite Source
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #1143:
URL: https://github.com/apache/incubator-seatunnel/pull/1143#discussion_r790393339
##########
File path: seatunnel-apis/seatunnel-api-spark/src/main/scala/org/apache/seatunnel/spark/batch/SparkBatchExecution.scala
##########
@@ -60,6 +60,7 @@ class SparkBatchExecution(environment: SparkEnvironment)
SparkBatchExecution.sinkProcess(environment, sink, ds)
})
// }
+ environment.getSparkSession.stop()
Review comment:
Why does the session stop here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1143: [Feature] [connector] Add Spark Ignite Source
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1143:
URL: https://github.com/apache/incubator-seatunnel/pull/1143#issuecomment-1038564613
I'll close it due to no feedback for a long time, if you make an update, leave a comment below and I'll reopen it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on a change in pull request #1143: [Feature #1127][Plugin]Add Spark Ignite Source
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on a change in pull request #1143:
URL: https://github.com/apache/incubator-seatunnel/pull/1143#discussion_r791238188
##########
File path: seatunnel-connectors/seatunnel-connector-spark-ignite/pom.xml
##########
@@ -0,0 +1,56 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>seatunnel-connectors</artifactId>
+ <groupId>org.apache.seatunnel</groupId>
+ <version>2.0.5-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>seatunnel-connector-spark-ignite</artifactId>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-api-spark</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.ignite</groupId>
+ <artifactId>ignite-spark-2.4</artifactId>
+ </dependency>
Review comment:
Please define this version number in parent `pom.xml` , thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs closed pull request #1143: [Feature] [connector] Add Spark Ignite Source
Posted by GitBox <gi...@apache.org>.
CalvinKirs closed pull request #1143:
URL: https://github.com/apache/incubator-seatunnel/pull/1143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1143: [Feature #1127][Plugin]Add Spark Ignite Source
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1143:
URL: https://github.com/apache/incubator-seatunnel/pull/1143#issuecomment-1020183994
> @CalvinKirs if developer should update **tools/dependencies/known-dependencies.txt** or not ？
yup, checklist has corresponding docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] RickyHuo commented on pull request #1143: [Feature #1127][Plugin]Add Spark Ignite Source
Posted by GitBox <gi...@apache.org>.
RickyHuo commented on pull request #1143:
URL: https://github.com/apache/incubator-seatunnel/pull/1143#issuecomment-1020166955
@CalvinKirs if developer should update **tools/dependencies/known-dependencies.txt** or not ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on a change in pull request #1143: [Feature #1127][Plugin]Add Spark Ignite Source
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on a change in pull request #1143:
URL: https://github.com/apache/incubator-seatunnel/pull/1143#discussion_r791237361
##########
File path: docs/en/spark/configuration/source-plugins/Ignite.md
##########
@@ -0,0 +1,41 @@
+# Source plugin: Ignite
+
+### Description
+
+Read data from Ignite.
+
+### Options
+
+| name | type | required | default value |
+| -------------- | ------ | -------- | ------------- |
+| [table](#table-string) | string | yes | - |
+| [config.file.path](#config.file.path-string) | string | yes | - |
+
Review comment:
If I remember correctly `result_table_name` seems to be required, please check, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org