You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/16 04:32:00 UTC
[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to
cause unpredictable behavior
[ https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=185563&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185563 ]
ASF GitHub Bot logged work on BEAM-6447:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jan/19 04:31
Start Date: 16/Jan/19 04:31
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7531: [BEAM-6447] Turn off spotless paddedCell
URL: https://github.com/apache/beam/pull/7531
Our use of paddedCell seems to have triggered some strange spotlessBehavior that is probably a bug in spotless. But we don't need it, so turn it off. It is a workaround only if `google-java-format` has a bug.
------------------------
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 185563)
Time Spent: 10m
Remaining Estimate: 0h
> Spotless paddedCell appears to cause unpredictable behavior
> -----------------------------------------------------------
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and https://github.com/apache/beam/pull/7527 spotlessApply was run and the result _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use of paddedCell is to workaround bugs in the underlying formatter (in our case google-java-format). Currently, there is no known bug affecting us, so we should not be using paddedCell.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)