You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "heljoyLiu (GitHub)" <gi...@apache.org> on 2020/03/16 03:05:50 UTC
[GitHub] [tinkerpop] heljoyLiu opened pull request #1264:
gremlin-python: add session mode client
[ Full content available at: https://github.com/apache/tinkerpop/pull/1264 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] heljoyLiu commented on issue #1264:
gremlin-python: add session mode client
Posted by "heljoyLiu (GitHub)" <gi...@apache.org>.
> If you'd like to add that here on this PR that will be fine, though for some reason you target `3.4-dev` with this PR but all other languages went to `3.3-dev` - I think this change should be re-targetted to `3.3-dev` to be consistent at this point. Please let me know if you think differently for some reason.
ok, I will re-target to `3.3-dev` branch
[ Full content available at: https://github.com/apache/tinkerpop/pull/1264 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] heljoyLiu commented on issue #1264:
gremlin-python: add session mode client
Posted by "heljoyLiu (GitHub)" <gi...@apache.org>.
> I think for the first two items we can just refer to this feature generally - no need to have one changelog/upgrade section per language.
I see, another PR for `3.3-dev` is ready, and I will make one for JavaScript for `close message` too.
To the end, update the first two items
[ Full content available at: https://github.com/apache/tinkerpop/pull/1264 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on issue #1264:
gremlin-python: add session mode client
Posted by "spmallette (GitHub)" <gi...@apache.org>.
I referenced this one from #1263 (`3.4-dev`)which added sessions for .NET. it is linked with #1257 (`3.3-dev`) and #1251 (javascript) With the addition of this PR it would mean that we have session support across all internally managed drivers. So far, I'm not sure if any of these changes have added any documentation and that needs to be rectified with the merge of this one.
Ideally we need:
1. CHANGELOG entry.
2. Upgrade documentation.
3. Adjust text of "[Considering Sessions](https://tinkerpop.apache.org/docs/current/reference/#sessions)" section in the Reference Documentation and add examples in each language.
I think for the first two items we can just refer to this feature generally - no need to have one changelog/upgrade section per language.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1264 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org