[GitHub] [yunikorn-k8shim] bgrams commented on a diff in pull request #532: [YUNIKORN-1555] Filter out terminated pods during recovery

["bgrams (via GitHub)" <gi...@apache.org>]

bgrams commented on code in PR #532:
URL: https://github.com/apache/yunikorn-k8shim/pull/532#discussion_r1199839787


##########
pkg/appmgmt/general/general.go:
##########
@@ -236,7 +236,7 @@ func (os *Manager) ListPods() ([]*v1.Pod, error) {
 		log.Logger().Debug("Looking at pod for recovery candidates", zap.String("podNamespace", pod.Namespace), zap.String("podName", pod.Name))
 		// general filter passes, and pod is assigned
 		// this means the pod is already scheduled by scheduler for an existing app
-		if utils.GeneralPodFilter(pod) && utils.IsAssignedPod(pod) {
+		if utils.GeneralPodFilter(pod) && utils.IsAssignedPod(pod) && !utils.IsPodTerminated(pod) {

Review Comment:
   Addressed in latest commits



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org