[jira] [Work logged] (GOBBLIN-800) Remove the metric context cache from GobblinMetricsRegistry

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-800?focusedWorklogId=256151&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-256151 ]

ASF GitHub Bot logged work on GOBBLIN-800:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Jun/19 18:50
            Start Date: 07/Jun/19 18:50
    Worklog Time Spent: 10m 
      Work Description: yukuai518 commented on pull request #2667: [GOBBLIN-800] Remove the metric context cache from GobblinMetricsRegistry
URL: https://github.com/apache/incubator-gobblin/pull/2667
 
 
   Remove the metric context cache from GobblinMetricsRegistry
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-800
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
      1) Create the ForkMetrics that can be used by Fork constrct when creating the metric context.
      2) Add the clean up logic in the GobblinMultiTaskAttempt to remove the metrics context hold by GobblinMetricsRegistry.
      3) Fix the Nullpointer exception due to an uninitialized taskAttemptId field inside of the TaskState deserialization.
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
      Rerun ClusterIntegrationTest
      Rerun MRJobLauncher test
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 256151)
            Time Spent: 10m
    Remaining Estimate: 0h

> Remove the metric context cache from GobblinMetricsRegistry
> -----------------------------------------------------------
>
>                 Key: GOBBLIN-800
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-800
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Kuai Yu
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Remove the metric context cache from GobblinMetricsRegistry



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)