You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/28 02:33:22 UTC

[GitHub] [pulsar] Anonymitaet edited a comment on pull request #11085: Support socks5 proxy

Anonymitaet edited a comment on pull request #11085:
URL: https://github.com/apache/pulsar/pull/11085#issuecomment-869288891


   @Technoboy- many thanks for your details!
   
   As we called just now, could you please help add docs and ping me review?
   
   You might need to:
   
   1. Check to which versions the doc will be added.
   - If you want to modify `master` doc, go [here](https://github.com/apache/pulsar/tree/master/site2/docs).
   - If you want to modify `versioned` docs, go [here](https://github.com/apache/pulsar/tree/master/site2/website/versioned_docs).
   
   2. Add docs (3 parameters and add necessary descipritons) [here](https://pulsar.apache.org/docs/en/next/client-libraries-java/#client)
   ![image](https://user-images.githubusercontent.com/50226895/123570190-4d15c400-d7fa-11eb-8b92-97f9e08f82f6.png)
   
   3. Besides, [this](https://docs.google.com/spreadsheets/d/1iTzn6QnOpTYK8QQHxXRb6a25nvuTNGPPJDdUQHGBUS4/edit#gid=1784579914) is the doc architecture for various clients, you can take it as a refernece. 
   
   ---
   
   **Tip**
   
   [Java Client API website (doc)](https://pulsar.apache.org/api/client/2.9.0-SNAPSHOT/) is automatically generated from [its code](https://github.com/apache/pulsar/tree/master/pulsar-client-api/src/main/java/org/apache/pulsar/client/api).
   
   If you add descriptions (like you did [here](https://github.com/apache/pulsar/pull/11085/files#diff-33219b2b08e58d5841feb88fdae064889f2477fd77564044ff4bb4e8fc24f1f9) ), you've already added docs for the Java API website. (@codelipenghui  so do not remove the ` component/documentation` label from this PR, I've labeled it back. Anyway many thanks for your label :-D)
   
   ![image](https://user-images.githubusercontent.com/50226895/123570724-68350380-d7fb-11eb-947d-cd75b20f61c9.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org