You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/27 01:21:21 UTC

[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #19025: Numpy pick large tensor fix

Zha0q1 opened a new pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025


   This pr fixes numpy pick against large tensors


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#issuecomment-681595133


   Jenkins CI successfully triggered : [unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#discussion_r478577604



##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -696,16 +696,16 @@ def test_one_hot():
     assert A.grad[0] == 0
 
 @use_np
-@pytest.mark.skip(reason='backward value broken on large tensor')
 def test_pick():
     A = np.zeros((INT_OVERFLOW, 2))
     B = np.zeros((INT_OVERFLOW))
+    A[0, 0] = 3

Review comment:
       sure I can also check the value of a large index.
   However because  this issue (assigment operator bug)https://github.com/apache/incubator-mxnet/issues/19014 we cannot set the value of a large index




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#issuecomment-684101369


   Jenkins CI successfully triggered : [unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 edited a comment on pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 edited a comment on pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#issuecomment-684101276


   @mxnet-bot run ci [unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#discussion_r478577604



##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -696,16 +696,16 @@ def test_one_hot():
     assert A.grad[0] == 0
 
 @use_np
-@pytest.mark.skip(reason='backward value broken on large tensor')
 def test_pick():
     A = np.zeros((INT_OVERFLOW, 2))
     B = np.zeros((INT_OVERFLOW))
+    A[0, 0] = 3

Review comment:
       sure I can also check the value of a large index.
   However because https://github.com/apache/incubator-mxnet/issues/19014 this issue (assigment operator bug) we cannot set the value of a large index




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#discussion_r478704437



##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -696,16 +696,16 @@ def test_one_hot():
     assert A.grad[0] == 0
 
 @use_np
-@pytest.mark.skip(reason='backward value broken on large tensor')
 def test_pick():
     A = np.zeros((INT_OVERFLOW, 2))
     B = np.zeros((INT_OVERFLOW))
+    A[0, 0] = 3

Review comment:
       In that case I can prioritize assignment operator next week and come back to this pr in a few days




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] access2rohit commented on pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#issuecomment-681986382


   pytest run results ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#issuecomment-681218667


   Hey @Zha0q1 , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [clang, miscellaneous, unix-gpu, website, windows-gpu, centos-cpu, unix-cpu, sanity, edge, windows-cpu, centos-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#discussion_r478704114



##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -696,16 +696,16 @@ def test_one_hot():
     assert A.grad[0] == 0
 
 @use_np
-@pytest.mark.skip(reason='backward value broken on large tensor')
 def test_pick():
     A = np.zeros((INT_OVERFLOW, 2))
     B = np.zeros((INT_OVERFLOW))
+    A[0, 0] = 3

Review comment:
       Accessing the element actually works fine. But I totally agree with you in that to be 100% confident, I can fix assignment operator first and then try this test again by setting a value of large index to something and then picking it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#issuecomment-684070669


   Jenkins CI successfully triggered : [unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#issuecomment-684101301


   Undefined action detected. 
   Permissible actions are : run ci [all], run ci [job1, job2] 
   Example : @mxnet-bot run ci [all] 
   Example : @mxnet-bot run ci [centos-cpu, clang]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#discussion_r478577604



##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -696,16 +696,16 @@ def test_one_hot():
     assert A.grad[0] == 0
 
 @use_np
-@pytest.mark.skip(reason='backward value broken on large tensor')
 def test_pick():
     A = np.zeros((INT_OVERFLOW, 2))
     B = np.zeros((INT_OVERFLOW))
+    A[0, 0] = 3

Review comment:
       sure I can also check the value of a large index.
   However because https://github.com/apache/incubator-mxnet/issues/19014 this issue (assigment operator bug) we cannot modify the value of a large index




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#discussion_r478701864



##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -696,16 +696,16 @@ def test_one_hot():
     assert A.grad[0] == 0
 
 @use_np
-@pytest.mark.skip(reason='backward value broken on large tensor')
 def test_pick():
     A = np.zeros((INT_OVERFLOW, 2))
     B = np.zeros((INT_OVERFLOW))
+    A[0, 0] = 3

Review comment:
       Since the operator is `pick` and it returns values of indices provided in second argument. I wouldn't say its fixed then because you are unable to access large indices by passing them as argument. You should perhaps look into `operator=` implementation of this. Let me know if you think thats not that case or if i could explain it a bit more clearly




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#issuecomment-682101293


   Updated test
   run result:
   ```
   ubuntu@ip-172-31-38-169:~/incubator-mxnet$ pytest tests/nightly/test_np_large_array.py::test_pick
   /home/ubuntu/anaconda3/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject
     return f(*args, **kwds)
   /home/ubuntu/anaconda3/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject
     return f(*args, **kwds)
   /home/ubuntu/anaconda3/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject
     return f(*args, **kwds)
   ============================================ test session starts =============================================
   platform linux -- Python 3.7.7, pytest-5.4.1, py-1.8.1, pluggy-0.13.1
   rootdir: /home/ubuntu/incubator-mxnet, inifile: pytest.ini
   plugins: remotedata-0.3.2, openfiles-0.4.0, astropy-header-0.1.2, hypothesis-5.8.3, arraydiff-0.3, doctestplus-0.5.0
   collected 1 item                                                                                             
   
   tests/nightly/test_np_large_array.py                                                                                                                                                                                                                    .                                                                 [100%]
   
   ============================================== warnings summary ==============================================
   tests/nightly/test_np_large_array.py:88
     /home/ubuntu/incubator-mxnet/tests/nightly/test_np_large_array.py:88: DeprecationWarning: invalid escape sequence \ 
       '''
   
   tests/nightly/test_np_large_array.py:568
     /home/ubuntu/incubator-mxnet/tests/nightly/test_np_large_array.py:568: DeprecationWarning: invalid escape sequence \ 
       '''
   
   -- Docs: https://docs.pytest.org/en/latest/warnings.html
   ================================= 1 passed, 2 warnings in 407.15s (0:06:47) ================================
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#issuecomment-681594962


   @mxnet-bot run ci [unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] sandeep-krishnamurthy merged pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy merged pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#issuecomment-684035812


   tweaked test to pick element of large index. Test passed locally:
   ```
   ubuntu@ip-172-31-38-169:~/incubator-mxnet$ pytest tests/nightly/test_np_large_array.py::test_pick
   /home/ubuntu/anaconda3/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject
     return f(*args, **kwds)
   /home/ubuntu/anaconda3/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject
     return f(*args, **kwds)
   /home/ubuntu/anaconda3/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject
     return f(*args, **kwds)
   ============================================ test session starts =============================================
   platform linux -- Python 3.7.7, pytest-5.4.1, py-1.8.1, pluggy-0.13.1
   rootdir: /home/ubuntu/incubator-mxnet, inifile: pytest.ini
   plugins: remotedata-0.3.2, openfiles-0.4.0, astropy-header-0.1.2, hypothesis-5.8.3, arraydiff-0.3, doctestplus-0.5.0
   collected 1 item                                                                                             
   
   tests/nightly/test_np_large_array.py                .                                                                 [100%]
   
   ======================================== 1 passed in 68.82s (0:01:08) =======================================
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#discussion_r478465933



##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -696,16 +696,16 @@ def test_one_hot():
     assert A.grad[0] == 0
 
 @use_np
-@pytest.mark.skip(reason='backward value broken on large tensor')
 def test_pick():
     A = np.zeros((INT_OVERFLOW, 2))
     B = np.zeros((INT_OVERFLOW))
+    A[0, 0] = 3

Review comment:
       Can you pick a very large index instead of 0 ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#issuecomment-684101276


   @mxnet-bot t run ci [unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
marcoabreu commented on a change in pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#discussion_r481258813



##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -696,16 +696,16 @@ def test_one_hot():
     assert A.grad[0] == 0
 
 @use_np
-@pytest.mark.skip(reason='backward value broken on large tensor')
 def test_pick():
     A = np.zeros((INT_OVERFLOW, 2))
     B = np.zeros((INT_OVERFLOW))
+    A[0, 0] = 3

Review comment:
       @Zha0q1 #19014 has been merged now




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19025: Numpy pick large tensor fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#issuecomment-684070648


   @mxnet-bot  run ci [unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org