You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Anton Pozhidaev (JIRA)" <ji...@apache.org> on 2019/04/08 17:10:00 UTC

[jira] [Comment Edited] (HTTPCLIENT-1982) Encoded equals(=) are not preservered

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812584#comment-16812584 ] 

Anton Pozhidaev edited comment on HTTPCLIENT-1982 at 4/8/19 5:09 PM:
---------------------------------------------------------------------

Hi [~olegk],

I believe it is not reserved in general for URI, but it is reserved for HTTP as it is used for parameters like [https://www.example.com/path?par1=val1&par2=val2]

In my case, it is looking like 

[https://www.example.com/path?par1=blah%3Dblah] but it is modified to [https://www.example.com/path?par1=blah=blah|https://www.example.com/path?par1=blah%3Dblah] I'll try to find some documentation about it.

*UPD*

The best info I could Find is section 3.4 of RFC3986 [https://tools.ietf.org/html/rfc3986#section-3.4]

Which states that "key=value" pairs are used in query (which assumes that "=" bears special meaning. However, RFC is indeed vague about encoding of get query. 

And also this SO post [https://stackoverflow.com/a/1455639/1079966] 


was (Author: pozhidaevak):
Hi [~olegk],

I believe it is not reserved in general for URI, but it is reserved for HTTP as it is used for parameters like [https://www.example.com/path?par1=val1&par2=val2]

In my case, it is looking like 

[https://www.example.com/path?par1=blah%3Dblah] but it is modified to [https://www.example.com/path?par1=blah=blah|https://www.example.com/path?par1=blah%3Dblah] I'll try to find some documentation about it

> Encoded equals(=) are not preservered
> -------------------------------------
>
>                 Key: HTTPCLIENT-1982
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1982
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.5.8
>            Reporter: Anton Pozhidaev
>            Priority: Major
>
> This issue is very similar to HTTPCLIENT-1968. 
> But instead of encoded slash, it affects encoded equals (%3D). 
> Encoded equals are decoded back in URL ( "%3D" => "=") *only if normalization is set to true*. 
> However, I believe this is shouldn't be part of normalization.
> The issue is happening somewhere inside URIBuilder.setPathSegments() which is called from 
> `rewriteURI(URI uri, HttpHost target, EnumSet<URIUtils.UriFlag> flags)` line 103
> PS. If the issue will be acknowledged as valid one I can try to prepare PR :) 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org