You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "plutaniano (via GitHub)" <gi...@apache.org> on 2025/05/22 18:18:55 UTC

[PR] Reverts "Fix PostgresHook Json serialization #49120" [airflow]

plutaniano opened a new pull request, #50978:
URL: https://github.com/apache/airflow/pull/50978

   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   Motivation in https://github.com/apache/airflow/issues/50976
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Reverts "Fix PostgresHook Json serialization #49120" [airflow]

Posted by "plutaniano (via GitHub)" <gi...@apache.org>.
plutaniano commented on PR #50978:
URL: https://github.com/apache/airflow/pull/50978#issuecomment-3148497355

   Issue fixed in https://github.com/apache/airflow/pull/53707.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Reverts "Fix PostgresHook Json serialization #49120" [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #50978:
URL: https://github.com/apache/airflow/pull/50978#issuecomment-3096142549

   Yeah. I think it would be great to get it done "well" :D 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Reverts "Fix PostgresHook Json serialization #49120" [airflow]

Posted by "VladaZakharova (via GitHub)" <gi...@apache.org>.
VladaZakharova commented on PR #50978:
URL: https://github.com/apache/airflow/pull/50978#issuecomment-3061711573

   Thank you for preparing the revert changes
   The changes you mentioned were added to fix one problem in Postrgres and I am afraid we need them too. Let my Team find a solution that will not break anything for you and for us and maybe we will find some consensus :)
   @olegkachur-e 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Reverts "Fix PostgresHook Json serialization #49120" [airflow]

Posted by "plutaniano (via GitHub)" <gi...@apache.org>.
plutaniano closed pull request #50978: Reverts "Fix PostgresHook Json serialization #49120"
URL: https://github.com/apache/airflow/pull/50978


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org