You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/05/10 20:40:36 UTC
Review Request 59116: Windows: Updated `support/windows-build.bat`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59116/
-----------------------------------------------------------
Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
Bugs: MESOS-7343
https://issues.apache.org/jira/browse/MESOS-7343
Repository: mesos
Description (updated)
-------
It now understands the environment variable `CMAKE_GENERATOR` so that
users can change the generator; the default is still Visual Studio 14.
Direct usage of `msbuild` was replaced with `cmake --build`.
We now build `mesos-tests` in the same pattern as `stout-tests` and
`libprocess-tests`. If admin priveleges are missing, we skip running the
tests, but still proceed to build the general target.
We set the CMake toolset instead of an environment variable for
`PreferredToolArchitecture`.
Diffs (updated)
-----
support/windows-build.bat 88e177ced912b61f8169b58a50d1cf6ba0c4c0c7
Diff: https://reviews.apache.org/r/59116/diff/1/
Testing (updated)
-------
Built and tested script with clean build on Windows.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 59116: Windows: Updated
`support/windows-build.bat`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59116/#review174987
-----------------------------------------------------------
Ship it!
I can fixup the few comments before committing.
support/windows-build.bat
Line 21 (original), 21 (patched)
<https://reviews.apache.org/r/59116/#comment248290>
Not sure why, but MSVC 15 changed the path to this script.
It is now:
```
/path/to/Microsoft Visual Studio/2017/Community/VC/Auxiliary/Build/vcvars64.bat
```
support/windows-build.bat
Line 52 (original), 52 (patched)
<https://reviews.apache.org/r/59116/#comment248289>
As discussed offline, we'll make this default to MSVC 15 (2017). Both the CIs have made the switch already.
support/windows-build.bat
Lines 87-89 (patched)
<https://reviews.apache.org/r/59116/#comment248288>
This part is not needed, as (currently) the `mesos-tests` target depends on all other targets being built first.
- Joseph Wu
On May 10, 2017, 1:40 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59116/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 1:40 p.m.)
>
>
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-7343
> https://issues.apache.org/jira/browse/MESOS-7343
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It now understands the environment variable `CMAKE_GENERATOR` so that
> users can change the generator; the default is still Visual Studio 14.
>
> Direct usage of `msbuild` was replaced with `cmake --build`.
>
> We now build `mesos-tests` in the same pattern as `stout-tests` and
> `libprocess-tests`. If admin priveleges are missing, we skip running the
> tests, but still proceed to build the general target.
>
> We set the CMake toolset instead of an environment variable for
> `PreferredToolArchitecture`.
>
>
> Diffs
> -----
>
> support/windows-build.bat 88e177ced912b61f8169b58a50d1cf6ba0c4c0c7
>
>
> Diff: https://reviews.apache.org/r/59116/diff/1/
>
>
> Testing
> -------
>
> Built and tested script with clean build on Windows.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 59116: Windows: Updated
`support/windows-build.bat`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On May 10, 2017, 9:19 p.m., Jeff Coffler wrote:
> > support/windows-build.bat
> > Line 52 (original), 52 (patched)
> > <https://reviews.apache.org/r/59116/diff/1/?file=1714224#file1714224line52>
> >
> > Is this correct? Did we deprecate older toolsets? I thought that, at this point, we REQUIRE the newer version of Visual Studio.
This is correct. We do not yet require, only warn that it is deprecated; and this commit does not change the default. If it did, I'd be forcing Joe to update Jenkins, but I'm not (yet anyway).
> On May 10, 2017, 9:19 p.m., Jeff Coffler wrote:
> > support/windows-build.bat
> > Line 61 (original)
> > <https://reviews.apache.org/r/59116/diff/1/?file=1714224#file1714224line62>
> >
> > Since we're shifting from msbuild to cmake to build, does cmake assume /m (parallel builds)?
Yes.
> On May 10, 2017, 9:19 p.m., Jeff Coffler wrote:
> > support/windows-build.bat
> > Line 68 (original), 57 (patched)
> > <https://reviews.apache.org/r/59116/diff/1/?file=1714224#file1714224line69>
> >
> > I know that we don't support NOT building Debug right now, but shouldn't this be configurable for windows-build.bat, perhaps with the default to build with debug?
We don't support it yet, so I didn't add it as a broken option.
> On May 10, 2017, 9:19 p.m., Jeff Coffler wrote:
> > support/windows-build.bat
> > Line 83 (original), 72 (patched)
> > <https://reviews.apache.org/r/59116/diff/1/?file=1714224#file1714224line84>
> >
> > So this is actually different from Linux.
> >
> > On Linux, if you do a `make check`, libprocess, stout, and mesos tests are all run (even if one of them has an error). But on Windows with windows-build.bat, that's not the case.
> >
> > I think it should be. Perhaps save the error state so you can report (at the end) that libprocess and/or stout tests failed. But given that it's routine for one or more tests to fail today, it's annoying that windows-build.bat isn't as good as Linux in this regard.
Totally agree, but wasn't fixing that here. It's a separate issue (and would require more careful testing of the script).
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59116/#review174560
-----------------------------------------------------------
On May 10, 2017, 8:40 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59116/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 8:40 p.m.)
>
>
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-7343
> https://issues.apache.org/jira/browse/MESOS-7343
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It now understands the environment variable `CMAKE_GENERATOR` so that
> users can change the generator; the default is still Visual Studio 14.
>
> Direct usage of `msbuild` was replaced with `cmake --build`.
>
> We now build `mesos-tests` in the same pattern as `stout-tests` and
> `libprocess-tests`. If admin priveleges are missing, we skip running the
> tests, but still proceed to build the general target.
>
> We set the CMake toolset instead of an environment variable for
> `PreferredToolArchitecture`.
>
>
> Diffs
> -----
>
> support/windows-build.bat 88e177ced912b61f8169b58a50d1cf6ba0c4c0c7
>
>
> Diff: https://reviews.apache.org/r/59116/diff/1/
>
>
> Testing
> -------
>
> Built and tested script with clean build on Windows.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 59116: Windows: Updated
`support/windows-build.bat`.
Posted by Jeff Coffler <je...@taltos.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59116/#review174560
-----------------------------------------------------------
support/windows-build.bat
Line 52 (original), 52 (patched)
<https://reviews.apache.org/r/59116/#comment247708>
Is this correct? Did we deprecate older toolsets? I thought that, at this point, we REQUIRE the newer version of Visual Studio.
support/windows-build.bat
Line 61 (original)
<https://reviews.apache.org/r/59116/#comment247710>
Since we're shifting from msbuild to cmake to build, does cmake assume /m (parallel builds)?
support/windows-build.bat
Line 68 (original), 57 (patched)
<https://reviews.apache.org/r/59116/#comment247711>
I know that we don't support NOT building Debug right now, but shouldn't this be configurable for windows-build.bat, perhaps with the default to build with debug?
support/windows-build.bat
Line 83 (original), 72 (patched)
<https://reviews.apache.org/r/59116/#comment247712>
So this is actually different from Linux.
On Linux, if you do a `make check`, libprocess, stout, and mesos tests are all run (even if one of them has an error). But on Windows with windows-build.bat, that's not the case.
I think it should be. Perhaps save the error state so you can report (at the end) that libprocess and/or stout tests failed. But given that it's routine for one or more tests to fail today, it's annoying that windows-build.bat isn't as good as Linux in this regard.
- Jeff Coffler
On May 10, 2017, 8:40 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59116/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 8:40 p.m.)
>
>
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-7343
> https://issues.apache.org/jira/browse/MESOS-7343
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It now understands the environment variable `CMAKE_GENERATOR` so that
> users can change the generator; the default is still Visual Studio 14.
>
> Direct usage of `msbuild` was replaced with `cmake --build`.
>
> We now build `mesos-tests` in the same pattern as `stout-tests` and
> `libprocess-tests`. If admin priveleges are missing, we skip running the
> tests, but still proceed to build the general target.
>
> We set the CMake toolset instead of an environment variable for
> `PreferredToolArchitecture`.
>
>
> Diffs
> -----
>
> support/windows-build.bat 88e177ced912b61f8169b58a50d1cf6ba0c4c0c7
>
>
> Diff: https://reviews.apache.org/r/59116/diff/1/
>
>
> Testing
> -------
>
> Built and tested script with clean build on Windows.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 59116: Windows: Updated
`support/windows-build.bat`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59116/#review174598
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59155, 59156, 59157, 59116]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 10, 2017, 8:40 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59116/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 8:40 p.m.)
>
>
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-7343
> https://issues.apache.org/jira/browse/MESOS-7343
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It now understands the environment variable `CMAKE_GENERATOR` so that
> users can change the generator; the default is still Visual Studio 14.
>
> Direct usage of `msbuild` was replaced with `cmake --build`.
>
> We now build `mesos-tests` in the same pattern as `stout-tests` and
> `libprocess-tests`. If admin priveleges are missing, we skip running the
> tests, but still proceed to build the general target.
>
> We set the CMake toolset instead of an environment variable for
> `PreferredToolArchitecture`.
>
>
> Diffs
> -----
>
> support/windows-build.bat 88e177ced912b61f8169b58a50d1cf6ba0c4c0c7
>
>
> Diff: https://reviews.apache.org/r/59116/diff/1/
>
>
> Testing
> -------
>
> Built and tested script with clean build on Windows.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 59116: Windows: Updated
`support/windows-build.bat`.
Posted by Li Li <li...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59116/#review174603
-----------------------------------------------------------
Ship it!
Ship It!
- Li Li
On May 10, 2017, 8:40 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59116/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 8:40 p.m.)
>
>
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-7343
> https://issues.apache.org/jira/browse/MESOS-7343
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It now understands the environment variable `CMAKE_GENERATOR` so that
> users can change the generator; the default is still Visual Studio 14.
>
> Direct usage of `msbuild` was replaced with `cmake --build`.
>
> We now build `mesos-tests` in the same pattern as `stout-tests` and
> `libprocess-tests`. If admin priveleges are missing, we skip running the
> tests, but still proceed to build the general target.
>
> We set the CMake toolset instead of an environment variable for
> `PreferredToolArchitecture`.
>
>
> Diffs
> -----
>
> support/windows-build.bat 88e177ced912b61f8169b58a50d1cf6ba0c4c0c7
>
>
> Diff: https://reviews.apache.org/r/59116/diff/1/
>
>
> Testing
> -------
>
> Built and tested script with clean build on Windows.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 59116: Windows: Updated
`support/windows-build.bat`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On May 10, 2017, 9:21 p.m., Mesos Reviewbot Windows wrote:
> > Patch looks great!
> >
> > Reviews applied: [59155, 59156, 59157, 59116]
> >
> > Passed command: support\windows-build.bat
Hey look at that! Windows Reviewbot works :D
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59116/#review174562
-----------------------------------------------------------
On May 10, 2017, 8:40 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59116/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 8:40 p.m.)
>
>
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-7343
> https://issues.apache.org/jira/browse/MESOS-7343
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It now understands the environment variable `CMAKE_GENERATOR` so that
> users can change the generator; the default is still Visual Studio 14.
>
> Direct usage of `msbuild` was replaced with `cmake --build`.
>
> We now build `mesos-tests` in the same pattern as `stout-tests` and
> `libprocess-tests`. If admin priveleges are missing, we skip running the
> tests, but still proceed to build the general target.
>
> We set the CMake toolset instead of an environment variable for
> `PreferredToolArchitecture`.
>
>
> Diffs
> -----
>
> support/windows-build.bat 88e177ced912b61f8169b58a50d1cf6ba0c4c0c7
>
>
> Diff: https://reviews.apache.org/r/59116/diff/1/
>
>
> Testing
> -------
>
> Built and tested script with clean build on Windows.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 59116: Windows: Updated
`support/windows-build.bat`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59116/#review174562
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59155, 59156, 59157, 59116]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On May 10, 2017, 8:40 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59116/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 8:40 p.m.)
>
>
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-7343
> https://issues.apache.org/jira/browse/MESOS-7343
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It now understands the environment variable `CMAKE_GENERATOR` so that
> users can change the generator; the default is still Visual Studio 14.
>
> Direct usage of `msbuild` was replaced with `cmake --build`.
>
> We now build `mesos-tests` in the same pattern as `stout-tests` and
> `libprocess-tests`. If admin priveleges are missing, we skip running the
> tests, but still proceed to build the general target.
>
> We set the CMake toolset instead of an environment variable for
> `PreferredToolArchitecture`.
>
>
> Diffs
> -----
>
> support/windows-build.bat 88e177ced912b61f8169b58a50d1cf6ba0c4c0c7
>
>
> Diff: https://reviews.apache.org/r/59116/diff/1/
>
>
> Testing
> -------
>
> Built and tested script with clean build on Windows.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>