You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2019/04/08 16:46:26 UTC
[Bug 63325] New: Default body_min_rate not enabled in mod_reqtimeout
https://bz.apache.org/bugzilla/show_bug.cgi?id=63325
Bug ID: 63325
Summary: Default body_min_rate not enabled in mod_reqtimeout
Product: Apache httpd-2
Version: 2.4.39
Hardware: All
OS: Linux
Status: NEW
Severity: major
Priority: P2
Component: mod_reqtimeout
Assignee: bugs@httpd.apache.org
Reporter: oliver@watershed.co.uk
Target Milestone: ---
The changes to mod_reqtimeout made in 2.4.39 (as per bug 61310) have no default
for the body_min_rate parameter, contrary to both the documentation and the
behaviour of <=2.4.38.
This means that if no explicit RequestReadTimeout statement is made in
httpd.conf, by default the server will return a 408 timeout after 20s even if
the client is actively sending data to the server (e.g. for a large file
upload). I found this bug when users reported they could no longer upload files
to our websites.
I have tested under a fresh install of both Linux (Ubuntu) and FreeBSD (11 and
12).
While some distributions such as ubuntu explicitly define RequestReadTimeout in
their default config, the documentation states the default is
body=20,minrate=500 (which was correct for <=2.4.38). This means 2.4.39 breaks
file uploads where the documented default is relied on, which is why I've
marked this bug as major.
WORKAROUND: Explicitly set the default:
RequestReadTimeout handshake=0 header=20-40,MinRate=500 body=20,MinRate=500
in httpd.conf and reload.
It looks like the changes made to mod_reqtimeout in 2.4.39 were fairly major in
order to incorporate the new "handshake" stage, so although I've tried, I'm
afraid I'm unable to see where the problem might lie. Sorry I can't be more
help diagnosing this.
Many thanks.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63325] Default body_min_rate not enabled in mod_reqtimeout
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63325
--- Comment #2 from Oliver H <ol...@watershed.co.uk> ---
I would assume that defining a simple body=20 would automatically stop minrate
from working, so no: my report is based on when there are no RequestReadTimeout
declarations in any conf file (I grepped thoroughly to confirm).
Oliver
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63325] Default body_min_rate not enabled in mod_reqtimeout
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63325
geegirls3 <de...@hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--- Comment #9 from geegirls3 <de...@hotmail.com> ---
I'm using Apache/2.4.54 on AWS Linux2 (Red Hat) 2 server, mod_jk Tomcat9 and
Apache. I'm having this same issue for a large file uploads, although my app
still processes, any file over 2GB breaks the file upload to the server. I was
looking for RequestReadTimeout statement in the httpd.conf file but it does not
exist, how can I change this?
One other thing, if I append :8443 at the end of my url, then I'm able to
upload large files. Can someone help me with this?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63325] Default body_min_rate not enabled in mod_reqtimeout
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63325
--- Comment #1 from Yann Ylavic <yl...@gmail.com> ---
Thanks for the report.
Do you set RequestReadTimeout partly (e.g. body= but no ,MinRate=) or not at
all?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63325] Default body_min_rate not enabled in mod_reqtimeout
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63325
--- Comment #3 from Yann Ylavic <yl...@gmail.com> ---
Created attachment 36514
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36514&action=edit
Fix reqtimeout macros lowercase
The macros MRT_DEFAULT_*_MIN_RATE which contain the default value were
partially made lowercase for some magic, unfortunately the ones tested in
reqtimeout_hooks() were not renammed, hence the bug.
Could you please try with this patch?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63325] Default body_min_rate not enabled in mod_reqtimeout
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63325
--- Comment #5 from Oliver H <ol...@watershed.co.uk> ---
Huge thanks for the quick work, I can confirm the patch fixes the issue.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63325] Default body_min_rate not enabled in mod_reqtimeout
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63325
Rainer Jung <ra...@kippdata.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pmenzel+bz.apache.org@molge
| |n.mpg.de
--- Comment #7 from Rainer Jung <ra...@kippdata.de> ---
*** Bug 63617 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63325] Default body_min_rate not enabled in mod_reqtimeout
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63325
Christophe JAILLET <ch...@wanadoo.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #8 from Christophe JAILLET <ch...@wanadoo.fr> ---
This has been backported in 2.4.x in r1859376.
This is part of 2.4.40.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63325] Default body_min_rate not enabled in mod_reqtimeout
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63325
Yann Ylavic <yl...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |FixedInTrunk
--- Comment #4 from Yann Ylavic <yl...@gmail.com> ---
Fixed in r1857129, will propose a backport to next 2.4.x.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63325] Default body_min_rate not enabled in mod_reqtimeout
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63325
Yann Ylavic <yl...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |apache-bugs.a2@x25.pl
--- Comment #6 from Yann Ylavic <yl...@gmail.com> ---
*** Bug 63329 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org