[GitHub] [ignite] olegbevz commented on a change in pull request #8999: IGNITE-14523 .NET: Add string.Compare support to LINQ provider

[GitBox <gi...@apache.org>]

olegbevz commented on a change in pull request #8999:
URL: https://github.com/apache/ignite/pull/8999#discussion_r613406863



##########
File path: modules/platforms/dotnet/Apache.Ignite.Linq/Impl/MethodVisitor.cs
##########
@@ -329,6 +331,50 @@ private static void AppendAdjustment(CacheQueryExpressionVisitor visitor, int[]
             visitor.Parameters.Add(paramValue);
         }
 
+        /// <summary>
+        /// Get IgnoreCase parameter for string.Compare method
+        /// </summary>
+        /// <param name="expression"></param>
+        /// <returns></returns>
+        private static bool GetStringCompareIgnoreCaseParameter(Expression expression)
+        {
+            if (expression is ConstantExpression constant)
+            {
+                if (constant.Value is bool ignoreCase)
+                {
+                    return ignoreCase;
+                }
+            }
+
+            throw new ArgumentException("ignoreCase");            
+        }
+
+        /// <summary>
+        /// Visits string.Compare method
+        /// </summary>
+        /// <param name="expression"></param>
+        /// <param name="visitor"></param>
+        private static void VisitStringCompare(MethodCallExpression expression, CacheQueryExpressionVisitor visitor, bool ignoreCase)
+        {
+            visitor.ResultBuilder.Append("casewhen(");
+            if (ignoreCase) visitor.ResultBuilder.Append("lower(");
+            visitor.Visit(expression.Arguments[0]);
+            if (ignoreCase) visitor.ResultBuilder.Append(")");
+            visitor.ResultBuilder.Append(" = ");
+            if (ignoreCase) visitor.ResultBuilder.Append("lower(");
+            visitor.Visit(expression.Arguments[1]);
+            if (ignoreCase) visitor.ResultBuilder.Append(")");
+            visitor.ResultBuilder.Append(", 0, casewhen(");
+            visitor.ResultBuilder.Append("lower(");

Review comment:
       @ptupitsyn, I did what was easiest: updated VisitStringCompare method to use ignoreCase in both cases + updated unit tests




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org