[GitHub] [kyuubi] cfmcgrady commented on a diff in pull request #4953: [KYUUBI #4950][FOLLOWUP] Misc improvement for usage of SQLite

["cfmcgrady (via GitHub)" <gi...@apache.org>]

cfmcgrady commented on code in PR #4953:
URL: https://github.com/apache/kyuubi/pull/4953#discussion_r1227687982


##########
kyuubi-server/src/main/resources/sql/sqlite/metadata-store-schema-1.6.0.sqlite.sql:
##########
@@ -26,10 +26,10 @@ CREATE TABLE IF NOT EXISTS metadata(
     peer_instance_closed boolean default '0' -- closed by peer kyuubi instance
 );

Review Comment:
   curious, as `JDBCMetadataStore#getLatestSchemaUrl` always return the latest version of metadata store schema, and the SQLite support has been available since v1.8.0, do we still need to provide `metadata-store-schema-1.6.0.sqlite.sql`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org