[GitHub] [iceberg] shardulm94 commented on a change in pull request #1474: FIX: fix reader not getting closed.

[GitBox <gi...@apache.org>]

shardulm94 commented on a change in pull request #1474:
URL: https://github.com/apache/iceberg/pull/1474#discussion_r490617018



##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ReadConf.java
##########
@@ -165,12 +165,12 @@ ParquetFileReader reader() {
     return shouldSkip;
   }
 
-  private Map<Long, Long> generateOffsetToStartPos() {
-    ParquetFileReader fileReader = newReader(this.file, ParquetReadOptions.builder().build());

Review comment:
       @sudssf This needs to initialize a new reader as we want to get row positions relative to the start of the file and not start of the split. I think the only change that is necessary in this PR is to close the reader.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org