[GitHub] [spark] DHKold commented on a diff in pull request #40491: [SPARK-41006][K8S] Generate new ConfigMap names for each run

["DHKold (via GitHub)" <gi...@apache.org>]

DHKold commented on code in PR #40491:
URL: https://github.com/apache/spark/pull/40491#discussion_r1150554912


##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/submit/ClientSuite.scala:
##########
@@ -214,8 +221,6 @@ class ClientSuite extends SparkFunSuite with BeforeAndAfter {
     assert(secrets.nonEmpty)
     assert(configMaps.nonEmpty)
     val configMap = configMaps.head
-    assert(configMap.getMetadata.getName ===
-      KubernetesClientUtils.configMapNameDriver)

Review Comment:
   I wasn't sure what to test. Should I maybe ensure it is not empty?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org