You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by jl...@apache.org on 2022/11/11 17:34:52 UTC
[pinot] branch master updated: write helix logs into dedicated files (#9786)
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new d71049b307 write helix logs into dedicated files (#9786)
d71049b307 is described below
commit d71049b30742ec1b7a40e560baea9e9f8452e32b
Author: Haitao Zhang <ha...@startree.ai>
AuthorDate: Fri Nov 11 09:34:43 2022 -0800
write helix logs into dedicated files (#9786)
---
docker/images/pinot/etc/conf/pinot-broker-log4j2.xml | 19 +++++++++++++++++++
.../images/pinot/etc/conf/pinot-controller-log4j2.xml | 19 +++++++++++++++++++
docker/images/pinot/etc/conf/pinot-server-log4j2.xml | 19 +++++++++++++++++++
.../src/main/resources/conf/pinot-broker-log4j2.xml | 9 +++++++++
.../main/resources/conf/pinot-controller-log4j2.xml | 9 +++++++++
.../src/main/resources/conf/pinot-minion-log4j2.xml | 9 +++++++++
.../src/main/resources/conf/pinot-server-log4j2.xml | 9 +++++++++
7 files changed, 93 insertions(+)
diff --git a/docker/images/pinot/etc/conf/pinot-broker-log4j2.xml b/docker/images/pinot/etc/conf/pinot-broker-log4j2.xml
index b1ef2cb883..4f9919a90c 100644
--- a/docker/images/pinot/etc/conf/pinot-broker-log4j2.xml
+++ b/docker/images/pinot/etc/conf/pinot-broker-log4j2.xml
@@ -45,6 +45,21 @@
</Policies>
<DefaultRolloverStrategy max="10"/>
</RollingFile>
+ <RollingFile
+ name="brokerHelixLog"
+ fileName="${env:LOG_DIR}/pinotBrokerHelix.log"
+ filePattern="${env:LOG_DIR}/pinotBrokerHelix.%d{yyyy-MM-dd}.%i.log.gz"
+ immediateFlush="false">
+ <PatternLayout>
+ <Pattern>%d{yyyy/MM/dd HH:mm:ss.SSS} %p [%c{1}] [%t] %m%n</Pattern>
+ </PatternLayout>
+ <Policies>
+ <OnStartupTriggeringPolicy/>
+ <SizeBasedTriggeringPolicy size="20 MB"/>
+ <TimeBasedTriggeringPolicy/>
+ </Policies>
+ <DefaultRolloverStrategy max="10"/>
+ </RollingFile>
<RollingFile
name="querylog"
fileName="${env:LOG_DIR}/querylog.log"
@@ -68,6 +83,10 @@
<!-- Direct most logs to the log file -->
<AppenderRef ref="brokerLog"/>
</Root>
+ <!-- Output helix logs to dedicated files -->
+ <Logger name="org.apache.helix" level="info" additivity="false">
+ <AppenderRef ref="brokerHelixLog"/>
+ </Logger>
<!-- Output querylogs to its own file -->
<Logger name="org.apache.pinot.broker.querylog.QueryLogger" level="info" additivity="false">
<AppenderRef ref="queryLog"/>
diff --git a/docker/images/pinot/etc/conf/pinot-controller-log4j2.xml b/docker/images/pinot/etc/conf/pinot-controller-log4j2.xml
index c0be22bd19..6add95aa5a 100644
--- a/docker/images/pinot/etc/conf/pinot-controller-log4j2.xml
+++ b/docker/images/pinot/etc/conf/pinot-controller-log4j2.xml
@@ -44,6 +44,21 @@
</Policies>
<DefaultRolloverStrategy max="10"/>
</RollingFile>
+ <RollingFile
+ name="controllerHelixLog"
+ fileName="${env:LOG_DIR}/pinotControllerHelix.log"
+ filePattern="${env:LOG_DIR}/pinotControllerHelix.%d{yyyy-MM-dd}.%i.log.gz"
+ immediateFlush="false">
+ <PatternLayout>
+ <Pattern>%d{yyyy/MM/dd HH:mm:ss.SSS} %p [%c{1}] [%t] %m%n</Pattern>
+ </PatternLayout>
+ <Policies>
+ <OnStartupTriggeringPolicy/>
+ <SizeBasedTriggeringPolicy size="20 MB"/>
+ <TimeBasedTriggeringPolicy/>
+ </Policies>
+ <DefaultRolloverStrategy max="10"/>
+ </RollingFile>
</Appenders>
<Loggers>
<Root level="info" additivity="false">
@@ -52,6 +67,10 @@
<!-- Direct most logs to the log file -->
<AppenderRef ref="controllerLog"/>
</Root>
+ <!-- Output helix logs to dedicated files -->
+ <Logger name="org.apache.helix" level="info" additivity="false">
+ <AppenderRef ref="controllerHelixLog"/>
+ </Logger>
<!-- Output controller starter logs to the console -->
<Logger name="org.apache.pinot.controller.ControllerStarter" level="info" additivity="false">
<AppenderRef ref="console"/>
diff --git a/docker/images/pinot/etc/conf/pinot-server-log4j2.xml b/docker/images/pinot/etc/conf/pinot-server-log4j2.xml
index 535874094b..75372434fb 100644
--- a/docker/images/pinot/etc/conf/pinot-server-log4j2.xml
+++ b/docker/images/pinot/etc/conf/pinot-server-log4j2.xml
@@ -44,6 +44,21 @@
</Policies>
<DefaultRolloverStrategy max="10"/>
</RollingFile>
+ <RollingFile
+ name="serverHelixLog"
+ fileName="${env:LOG_DIR}/pinotServerHelix.log"
+ filePattern="${env:LOG_DIR}/pinotServerHelix.%d{yyyy-MM-dd}.%i.log.gz"
+ immediateFlush="false">
+ <PatternLayout>
+ <Pattern>%d{yyyy/MM/dd HH:mm:ss.SSS} %p [%c{1}] [%t] %m%n</Pattern>
+ </PatternLayout>
+ <Policies>
+ <OnStartupTriggeringPolicy/>
+ <SizeBasedTriggeringPolicy size="20 MB"/>
+ <TimeBasedTriggeringPolicy/>
+ </Policies>
+ <DefaultRolloverStrategy max="10"/>
+ </RollingFile>
</Appenders>
<Loggers>
<Root level="info" additivity="false">
@@ -52,6 +67,10 @@
<!-- Direct most logs to the log file -->
<AppenderRef ref="serverLog"/>
</Root>
+ <!-- Output helix logs to dedicated files -->
+ <Logger name="org.apache.helix" level="info" additivity="false">
+ <AppenderRef ref="serverHelixLog"/>
+ </Logger>
<!-- Output server starter logs to the console -->
<Logger name="org.apache.pinot.server.starter.helix.HelixServerStarter" level="info" additivity="false">
<AppenderRef ref="console"/>
diff --git a/pinot-tools/src/main/resources/conf/pinot-broker-log4j2.xml b/pinot-tools/src/main/resources/conf/pinot-broker-log4j2.xml
index 190c3fe1be..ff210f978e 100644
--- a/pinot-tools/src/main/resources/conf/pinot-broker-log4j2.xml
+++ b/pinot-tools/src/main/resources/conf/pinot-broker-log4j2.xml
@@ -31,6 +31,11 @@
<Pattern>%d{yyyy/MM/dd HH:mm:ss.SSS} %p [%c{1}] [%t] %m%n</Pattern>
</PatternLayout>
</RandomAccessFile>
+ <RandomAccessFile name="brokerHelixLog" fileName="pinotBrokerHelix.log" immediateFlush="false">
+ <PatternLayout>
+ <Pattern>%d{yyyy/MM/dd HH:mm:ss.SSS} %p [%c{1}] [%t] %m%n</Pattern>
+ </PatternLayout>
+ </RandomAccessFile>
<RandomAccessFile name="querylog" fileName="querylog.log" immediateFlush="false">
<PatternLayout>
<Pattern>%d{yyyy/MM/dd HH:mm:ss.SSS} %p [%c{1}] [%t] %m%n</Pattern>
@@ -44,6 +49,10 @@
<!-- Direct most logs to the log file -->
<AppenderRef ref="brokerLog"/>
</Root>
+ <!-- Output helix logs to a dedicated file-->
+ <Logger name="org.apache.helix" level="info" additivity="false">
+ <AppenderRef ref="brokerHelixLog"/>
+ </Logger>
<!-- Output query logs to a dedicated file-->
<Logger name="org.apache.pinot.broker.querylog.QueryLogger" level="debug" additivity="false">
<AppenderRef ref="querylog"/>
diff --git a/pinot-tools/src/main/resources/conf/pinot-controller-log4j2.xml b/pinot-tools/src/main/resources/conf/pinot-controller-log4j2.xml
index e417a1d9fe..2f071f51bd 100644
--- a/pinot-tools/src/main/resources/conf/pinot-controller-log4j2.xml
+++ b/pinot-tools/src/main/resources/conf/pinot-controller-log4j2.xml
@@ -31,6 +31,11 @@
<Pattern>%d{yyyy/MM/dd HH:mm:ss.SSS} %p [%c{1}] [%t] %m%n</Pattern>
</PatternLayout>
</RandomAccessFile>
+ <RandomAccessFile name="controllerHelixLog" fileName="pinotControllerHelix.log" immediateFlush="false">
+ <PatternLayout>
+ <Pattern>%d{yyyy/MM/dd HH:mm:ss.SSS} %p [%c{1}] [%t] %m%n</Pattern>
+ </PatternLayout>
+ </RandomAccessFile>
</Appenders>
<Loggers>
<Root level="info" additivity="false">
@@ -39,6 +44,10 @@
<!-- Direct most logs to the log file -->
<AppenderRef ref="controllerLog"/>
</Root>
+ <!-- Output helix logs to a dedicated file-->
+ <Logger name="org.apache.helix" level="info" additivity="false">
+ <AppenderRef ref="controllerHelixLog"/>
+ </Logger>
<!-- Output controller starter logs to the console -->
<Logger name="org.apache.pinot.controller.ControllerStarter" level="info" additivity="false">
<AppenderRef ref="console"/>
diff --git a/pinot-tools/src/main/resources/conf/pinot-minion-log4j2.xml b/pinot-tools/src/main/resources/conf/pinot-minion-log4j2.xml
index b8d272be2a..4c6c794d0d 100644
--- a/pinot-tools/src/main/resources/conf/pinot-minion-log4j2.xml
+++ b/pinot-tools/src/main/resources/conf/pinot-minion-log4j2.xml
@@ -31,6 +31,11 @@
<Pattern>%d{yyyy/MM/dd HH:mm:ss.SSS} %p [%c{1}] [%t] %m%n</Pattern>
</PatternLayout>
</RandomAccessFile>
+ <RandomAccessFile name="minionHelixLog" fileName="pinotMinionHelix.log" immediateFlush="false">
+ <PatternLayout>
+ <Pattern>%d{yyyy/MM/dd HH:mm:ss.SSS} %p [%c{1}] [%t] %m%n</Pattern>
+ </PatternLayout>
+ </RandomAccessFile>
</Appenders>
<Loggers>
<Root level="info" additivity="false">
@@ -39,6 +44,10 @@
<!-- Direct most logs to the log file -->
<AppenderRef ref="minionLog"/>
</Root>
+ <!-- Output helix logs to a dedicated file-->
+ <Logger name="org.apache.helix" level="info" additivity="false">
+ <AppenderRef ref="minionHelixLog"/>
+ </Logger>
<!-- Output server starter logs to the console -->
<Logger name="org.apache.pinot.minion.MinionStarter" level="info" additivity="false">
<AppenderRef ref="console"/>
diff --git a/pinot-tools/src/main/resources/conf/pinot-server-log4j2.xml b/pinot-tools/src/main/resources/conf/pinot-server-log4j2.xml
index 78af9ff21d..d50e20213f 100644
--- a/pinot-tools/src/main/resources/conf/pinot-server-log4j2.xml
+++ b/pinot-tools/src/main/resources/conf/pinot-server-log4j2.xml
@@ -31,6 +31,11 @@
<Pattern>%d{yyyy/MM/dd HH:mm:ss.SSS} %p [%c{1}] [%t] %m%n</Pattern>
</PatternLayout>
</RandomAccessFile>
+ <RandomAccessFile name="serverHelixLog" fileName="pinotServerHelix.log" immediateFlush="false">
+ <PatternLayout>
+ <Pattern>%d{yyyy/MM/dd HH:mm:ss.SSS} %p [%c{1}] [%t] %m%n</Pattern>
+ </PatternLayout>
+ </RandomAccessFile>
</Appenders>
<Loggers>
<Root level="info" additivity="false">
@@ -39,6 +44,10 @@
<!-- Direct most logs to the log file -->
<AppenderRef ref="serverLog"/>
</Root>
+ <!-- Output helix logs to a dedicated file-->
+ <Logger name="org.apache.helix" level="info" additivity="false">
+ <AppenderRef ref="serverHelixLog"/>
+ </Logger>
<!-- Output server starter logs to the console -->
<Logger name="org.apache.pinot.server.starter.helix.HelixServerStarter" level="info" additivity="false">
<AppenderRef ref="console"/>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org