You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/03/01 02:31:45 UTC
Review Request 65851: Disallow limit in /quota requests and SET_QUOTA
calls.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65851/
-----------------------------------------------------------
Review request for mesos, Michael Park and Meng Zhu.
Repository: mesos
Description
-------
This ensures that after the protobuf changes to introduce limit
are committed, users cannot set limit in the existing API.
Diffs
-----
src/master/quota.cpp 58bab6a678bac9e41a7994ba0b7cc1ed069a8a18
Diff: https://reviews.apache.org/r/65851/diff/1/
Testing
-------
Test added in the subsequent patch.
Thanks,
Benjamin Mahler
Re: Review Request 65851: Disallow limit in /quota requests and
SET_QUOTA calls.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65851/#review199387
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On March 9, 2018, 5:46 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65851/
> -----------------------------------------------------------
>
> (Updated March 9, 2018, 5:46 p.m.)
>
>
> Review request for mesos, Michael Park and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This ensures that after the protobuf changes to introduce limit
> are committed, users cannot set limit in the existing API.
>
>
> Diffs
> -----
>
> src/master/quota.cpp 58bab6a678bac9e41a7994ba0b7cc1ed069a8a18
>
>
> Diff: https://reviews.apache.org/r/65851/diff/2/
>
>
> Testing
> -------
>
> Test added in the subsequent patch.
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 65851: Disallow limit in /quota requests and
SET_QUOTA calls.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65851/
-----------------------------------------------------------
(Updated March 10, 2018, 1:46 a.m.)
Review request for mesos, Michael Park and Meng Zhu.
Changes
-------
Added a TODO per meng's suggestion.
Repository: mesos
Description
-------
This ensures that after the protobuf changes to introduce limit
are committed, users cannot set limit in the existing API.
Diffs (updated)
-----
src/master/quota.cpp 58bab6a678bac9e41a7994ba0b7cc1ed069a8a18
Diff: https://reviews.apache.org/r/65851/diff/2/
Changes: https://reviews.apache.org/r/65851/diff/1-2/
Testing
-------
Test added in the subsequent patch.
Thanks,
Benjamin Mahler
Re: Review Request 65851: Disallow limit in /quota requests and
SET_QUOTA calls.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65851/#review198842
-----------------------------------------------------------
src/master/quota.cpp
Lines 166-171 (patched)
<https://reviews.apache.org/r/65851/#comment279090>
Hmm, it is surprising to me that this check is put here. I think the assumption here is that this function is called only by quota `set()`. This is not obvious. Let's add a todo here to either consolidate this with the new `quotaRequest` validation or put this limit check into the master call validation.
- Meng Zhu
On Feb. 28, 2018, 6:31 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65851/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 6:31 p.m.)
>
>
> Review request for mesos, Michael Park and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This ensures that after the protobuf changes to introduce limit
> are committed, users cannot set limit in the existing API.
>
>
> Diffs
> -----
>
> src/master/quota.cpp 58bab6a678bac9e41a7994ba0b7cc1ed069a8a18
>
>
> Diff: https://reviews.apache.org/r/65851/diff/1/
>
>
> Testing
> -------
>
> Test added in the subsequent patch.
>
>
> Thanks,
>
> Benjamin Mahler
>
>