You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Filip Hanik - Dev Lists <de...@hanik.com> on 2008/07/17 03:47:48 UTC
Feedback for Bayeux contribution
I'd like some feedback on the contribution, before I call for a vote for
inclusion
thanks
Filip
bugzilla@apache.org wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=45413
>
> Summary: Contribution of Bayeux implementation for Tomcat
> Product: Tomcat 6
> Version: 6.0.16
> Platform: All
> URL: http://svn.hanik.com/svn/repos/tomcat-bayeux
> OS/Version: All
> Status: NEW
> Severity: enhancement
> Priority: P2
> Component: Catalina
> AssignedTo: tomcat-dev@jakarta.apache.org
> ReportedBy: fhanik@apache.org
>
>
> Created an attachment (id=22267)
> --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22267)
> Contribution of code
>
> The following bugzilla issue is a contribution of a codebase from Filip
> Hanik(asf:fhanik) and Guy Molinari(individual)
> Both have ICLAs on file with the ASF.
>
> Description:
> The contribution is two fold
>
> 1. The core implementation
> Core implementation of the Bayeux protocol using Comet and HTTP
> External dependencies: json.jar from json.org - Apache License 2.0
> packages:
> - org.apache.cometd.bayeux
> APIs for web application developers
> derived from a proposed but incomplete API by Dojo Foundation
> - org.apache.tomcat.bayeux
> implementation of API classes
>
> 2. The sample applications
> External dependencies: Dojo Toolkit, license:
> http://trac.dojotoolkit.org/browser/dojo/trunk/LICENSE#L13
>
> COPYRIGHT and LICENSE files included.
>
> The contribution is a full environment, to be able to download and build
> distributions. We don't expect everything to be merged in, instead we expect
> that the source code be integrated into tomcat/trunk and we can then modify the
> existing build scripts to fit into the Tomcat build/distribution scheme
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Feedback for Bayeux contribution
Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
Costin Manolache wrote:
> BTW - any docs associated with this ? For example, what's the relation with
> JMS and other products/APIs ?
>
> Briefly looking at the code - it would be nice to include javadocs at least
> on the public APIs,
org.apache.cometd.bayeux is javadoc:ed, that's the public API, nothing
but interfaces.
> and some indication
> of which are the public / frozen APIs and which are just impl methods that
> shouln't be used by apps.
>
the separatation is very clear org.apache.cometd.bayeux is public,
org.apache.tomcat.bayeux is private
> A small automated test would be extra nice ( if you really want feedback )
> :-)
>
yes, for sure, there is always stuff to do :)
> Costin
>
> On Wed, Jul 16, 2008 at 10:45 PM, Costin Manolache <co...@gmail.com> wrote:
>
>
>> I think this is a nice contribution ( haven't reviewed the code in detail
>> yet ), but seems like a separate enough feature
>> to be distributed as a separate/optional package.
>> I can't think of any good reason to include it in the base tomcat distro (
>> except that a lot of other stuff is there and
>> shouldn't ) - it is not required in order to implement http or servlet
>> specs, seems useful for a relatively narrow
>> user base, etc.
>>
>> Costin
>>
>>
>> On Wed, Jul 16, 2008 at 6:47 PM, Filip Hanik - Dev Lists <
>> devlists@hanik.com> wrote:
>>
>>
>>> I'd like some feedback on the contribution, before I call for a vote for
>>> inclusion
>>>
>>> thanks
>>> Filip
>>>
>>> bugzilla@apache.org wrote:
>>>
>>>
>>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=45413
>>>>
>>>> Summary: Contribution of Bayeux implementation for Tomcat
>>>> Product: Tomcat 6
>>>> Version: 6.0.16
>>>> Platform: All
>>>> URL: http://svn.hanik.com/svn/repos/tomcat-bayeux
>>>> OS/Version: All
>>>> Status: NEW
>>>> Severity: enhancement
>>>> Priority: P2
>>>> Component: Catalina
>>>> AssignedTo: tomcat-dev@jakarta.apache.org
>>>> ReportedBy: fhanik@apache.org
>>>>
>>>>
>>>> Created an attachment (id=22267)
>>>> --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22267)
>>>> Contribution of code
>>>>
>>>> The following bugzilla issue is a contribution of a codebase from Filip
>>>> Hanik(asf:fhanik) and Guy Molinari(individual)
>>>> Both have ICLAs on file with the ASF.
>>>>
>>>> Description:
>>>> The contribution is two fold
>>>>
>>>> 1. The core implementation
>>>> Core implementation of the Bayeux protocol using Comet and HTTP
>>>> External dependencies: json.jar from json.org - Apache License 2.0
>>>> packages: - org.apache.cometd.bayeux APIs for web application
>>>> developers
>>>> derived from a proposed but incomplete API by Dojo Foundation
>>>> - org.apache.tomcat.bayeux
>>>> implementation of API classes
>>>>
>>>> 2. The sample applications
>>>> External dependencies: Dojo Toolkit, license:
>>>> http://trac.dojotoolkit.org/browser/dojo/trunk/LICENSE#L13
>>>>
>>>> COPYRIGHT and LICENSE files included.
>>>>
>>>> The contribution is a full environment, to be able to download and build
>>>> distributions. We don't expect everything to be merged in, instead we
>>>> expect
>>>> that the source code be integrated into tomcat/trunk and we can then
>>>> modify the
>>>> existing build scripts to fit into the Tomcat build/distribution scheme
>>>>
>>>>
>>>>
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>>
>>>
>
>
> ------------------------------------------------------------------------
>
> No virus found in this incoming message.
> Checked by AVG.
> Version: 7.5.526 / Virus Database: 270.5.0/1556 - Release Date: 7/16/2008 4:56 PM
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Feedback for Bayeux contribution
Posted by Costin Manolache <co...@gmail.com>.
BTW - any docs associated with this ? For example, what's the relation with
JMS and other products/APIs ?
Briefly looking at the code - it would be nice to include javadocs at least
on the public APIs, and some indication
of which are the public / frozen APIs and which are just impl methods that
shouln't be used by apps.
A small automated test would be extra nice ( if you really want feedback )
:-)
Costin
On Wed, Jul 16, 2008 at 10:45 PM, Costin Manolache <co...@gmail.com> wrote:
> I think this is a nice contribution ( haven't reviewed the code in detail
> yet ), but seems like a separate enough feature
> to be distributed as a separate/optional package.
> I can't think of any good reason to include it in the base tomcat distro (
> except that a lot of other stuff is there and
> shouldn't ) - it is not required in order to implement http or servlet
> specs, seems useful for a relatively narrow
> user base, etc.
>
> Costin
>
>
> On Wed, Jul 16, 2008 at 6:47 PM, Filip Hanik - Dev Lists <
> devlists@hanik.com> wrote:
>
>> I'd like some feedback on the contribution, before I call for a vote for
>> inclusion
>>
>> thanks
>> Filip
>>
>> bugzilla@apache.org wrote:
>>
>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=45413
>>>
>>> Summary: Contribution of Bayeux implementation for Tomcat
>>> Product: Tomcat 6
>>> Version: 6.0.16
>>> Platform: All
>>> URL: http://svn.hanik.com/svn/repos/tomcat-bayeux
>>> OS/Version: All
>>> Status: NEW
>>> Severity: enhancement
>>> Priority: P2
>>> Component: Catalina
>>> AssignedTo: tomcat-dev@jakarta.apache.org
>>> ReportedBy: fhanik@apache.org
>>>
>>>
>>> Created an attachment (id=22267)
>>> --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22267)
>>> Contribution of code
>>>
>>> The following bugzilla issue is a contribution of a codebase from Filip
>>> Hanik(asf:fhanik) and Guy Molinari(individual)
>>> Both have ICLAs on file with the ASF.
>>>
>>> Description:
>>> The contribution is two fold
>>>
>>> 1. The core implementation
>>> Core implementation of the Bayeux protocol using Comet and HTTP
>>> External dependencies: json.jar from json.org - Apache License 2.0
>>> packages: - org.apache.cometd.bayeux APIs for web application
>>> developers
>>> derived from a proposed but incomplete API by Dojo Foundation
>>> - org.apache.tomcat.bayeux
>>> implementation of API classes
>>>
>>> 2. The sample applications
>>> External dependencies: Dojo Toolkit, license:
>>> http://trac.dojotoolkit.org/browser/dojo/trunk/LICENSE#L13
>>>
>>> COPYRIGHT and LICENSE files included.
>>>
>>> The contribution is a full environment, to be able to download and build
>>> distributions. We don't expect everything to be merged in, instead we
>>> expect
>>> that the source code be integrated into tomcat/trunk and we can then
>>> modify the
>>> existing build scripts to fit into the Tomcat build/distribution scheme
>>>
>>>
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>
Re: Feedback for Bayeux contribution
Posted by Costin Manolache <co...@gmail.com>.
I think this is a nice contribution ( haven't reviewed the code in detail
yet ), but seems like a separate enough feature
to be distributed as a separate/optional package.
I can't think of any good reason to include it in the base tomcat distro (
except that a lot of other stuff is there and
shouldn't ) - it is not required in order to implement http or servlet
specs, seems useful for a relatively narrow
user base, etc.
Costin
On Wed, Jul 16, 2008 at 6:47 PM, Filip Hanik - Dev Lists <de...@hanik.com>
wrote:
> I'd like some feedback on the contribution, before I call for a vote for
> inclusion
>
> thanks
> Filip
>
> bugzilla@apache.org wrote:
>
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=45413
>>
>> Summary: Contribution of Bayeux implementation for Tomcat
>> Product: Tomcat 6
>> Version: 6.0.16
>> Platform: All
>> URL: http://svn.hanik.com/svn/repos/tomcat-bayeux
>> OS/Version: All
>> Status: NEW
>> Severity: enhancement
>> Priority: P2
>> Component: Catalina
>> AssignedTo: tomcat-dev@jakarta.apache.org
>> ReportedBy: fhanik@apache.org
>>
>>
>> Created an attachment (id=22267)
>> --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22267)
>> Contribution of code
>>
>> The following bugzilla issue is a contribution of a codebase from Filip
>> Hanik(asf:fhanik) and Guy Molinari(individual)
>> Both have ICLAs on file with the ASF.
>>
>> Description:
>> The contribution is two fold
>>
>> 1. The core implementation
>> Core implementation of the Bayeux protocol using Comet and HTTP
>> External dependencies: json.jar from json.org - Apache License 2.0
>> packages: - org.apache.cometd.bayeux APIs for web application
>> developers
>> derived from a proposed but incomplete API by Dojo Foundation
>> - org.apache.tomcat.bayeux
>> implementation of API classes
>>
>> 2. The sample applications
>> External dependencies: Dojo Toolkit, license:
>> http://trac.dojotoolkit.org/browser/dojo/trunk/LICENSE#L13
>>
>> COPYRIGHT and LICENSE files included.
>>
>> The contribution is a full environment, to be able to download and build
>> distributions. We don't expect everything to be merged in, instead we
>> expect
>> that the source code be integrated into tomcat/trunk and we can then
>> modify the
>> existing build scripts to fit into the Tomcat build/distribution scheme
>>
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
Re: Feedback for Bayeux contribution
Posted by Costin Manolache <co...@gmail.com>.
Thanks, my +1 on committing it to tomcat, seems like a good start and a good
example on how to use the
async stuff.
Costin
On Thu, Jul 17, 2008 at 7:50 AM, Filip Hanik - Dev Lists <de...@hanik.com>
wrote:
> Costin Manolache wrote:
>
>> On Thu, Jul 17, 2008 at 7:00 AM, Filip Hanik - Dev Lists <
>> devlists@hanik.com>
>> wrote:
>>
>>
>>
>>> Remy Maucherat wrote:
>>>
>>>
>>>
>>>> On Thu, 2008-07-17 at 07:39 -0400, Yoav Shapira wrote:
>>>>
>>>>
>>>>
>>>>
>>>>> On Wed, Jul 16, 2008 at 9:47 PM, Filip Hanik - Dev Lists
>>>>> <de...@hanik.com> wrote:
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>> I'd like some feedback on the contribution, before I call for a vote
>>>>>> for
>>>>>> inclusion
>>>>>>
>>>>>> thanks
>>>>>> Filip
>>>>>>
>>>>>> bugzilla@apache.org wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=45413
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> I'm happy to welcome this contribution. It's refreshingly cool.
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>> OTOH, I haven't heard anything about bayeux lately. Is it actually
>>>> picking up enough adoption to be included with Tomcat ?
>>>>
>>>>
>>>>
>>>>
>>> I'd follow Costin's advice, have it be a separate component, if it does
>>> become popular, it can be considered for inclusion then
>>>
>>>
>>>
>>
>> Great, thank you.
>>
>> I assume the first step is to check in the code in tomcat ( based on the
>> bug
>> layout - looks like separate dir, which is probably better in this case ).
>> After that it'll follow the normal process for a release - and I hope
>> you'll
>> add more to README at least before release.
>>
>>
> of course, as well as documentation. but one has to start somewhere.
>
>> Few more questions:
>> I would guess that only part of it is specific to tomcat ( connector
>> interface ) - do you plan to have it support other servlet engines as well
>> (
>> wouldn't be a bad idea if you want adoption for your API - or bayeux ) ?
>>
>>
> this can of course be implemented as a regular servlet, but would be less
> resource efficient.
> doing it through comet, allows it to use the async io features.
> But I think it would be good to implement the service() method of
> BayeuxServlet, and then it would be portable
>
>> What kind of config is needed - and if any, is it in server.xml or can it
>> be
>> done via web.xml in apps that use it ?
>>
>>
> web.xml only
>
>> What kind of monitoring do you have/plan - didn't see any JMX. I guess
>> it'll
>> affect the number of open connections.
>>
>>
> number of open connections should be monitored at the tomcat level, but
> JMX should be on the road map in terms of what clients are connected, what
> channels they are subscribed to etc
>
> Filip
>
>>
>> Costin
>>
>>
>>
>>
>>
>>> Filip
>>>
>>>
>>> Rémy
>>>
>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> No virus found in this incoming message.
>>> Checked by AVG. Version: 7.5.526 / Virus Database: 270.5.0/1556 - Release
>>> Date: 7/16/2008 4:56 PM
>>>
>>>
>>
>
> ---------------------------------------------------------------------
>
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
Re: Feedback for Bayeux contribution
Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
Costin Manolache wrote:
> On Thu, Jul 17, 2008 at 7:00 AM, Filip Hanik - Dev Lists <de...@hanik.com>
> wrote:
>
>
>> Remy Maucherat wrote:
>>
>>
>>> On Thu, 2008-07-17 at 07:39 -0400, Yoav Shapira wrote:
>>>
>>>
>>>
>>>> On Wed, Jul 16, 2008 at 9:47 PM, Filip Hanik - Dev Lists
>>>> <de...@hanik.com> wrote:
>>>>
>>>>
>>>>
>>>>> I'd like some feedback on the contribution, before I call for a vote for
>>>>> inclusion
>>>>>
>>>>> thanks
>>>>> Filip
>>>>>
>>>>> bugzilla@apache.org wrote:
>>>>>
>>>>>
>>>>>
>>>>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=45413
>>>>>>
>>>>>>
>>>>>>
>>>>> I'm happy to welcome this contribution. It's refreshingly cool.
>>>>>
>>>>
>>> OTOH, I haven't heard anything about bayeux lately. Is it actually
>>> picking up enough adoption to be included with Tomcat ?
>>>
>>>
>>>
>> I'd follow Costin's advice, have it be a separate component, if it does
>> become popular, it can be considered for inclusion then
>>
>>
>
> Great, thank you.
>
> I assume the first step is to check in the code in tomcat ( based on the bug
> layout - looks like separate dir, which is probably better in this case ).
> After that it'll follow the normal process for a release - and I hope you'll
> add more to README at least before release.
>
of course, as well as documentation. but one has to start somewhere.
> Few more questions:
> I would guess that only part of it is specific to tomcat ( connector
> interface ) - do you plan to have it support other servlet engines as well (
> wouldn't be a bad idea if you want adoption for your API - or bayeux ) ?
>
this can of course be implemented as a regular servlet, but would be
less resource efficient.
doing it through comet, allows it to use the async io features.
But I think it would be good to implement the service() method of
BayeuxServlet, and then it would be portable
> What kind of config is needed - and if any, is it in server.xml or can it be
> done via web.xml in apps that use it ?
>
web.xml only
> What kind of monitoring do you have/plan - didn't see any JMX. I guess it'll
> affect the number of open connections.
>
number of open connections should be monitored at the tomcat level, but
JMX should be on the road map in terms of what clients are connected,
what channels they are subscribed to etc
Filip
>
> Costin
>
>
>
>
>> Filip
>>
>>
>> Rémy
>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>>
>>>
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> No virus found in this incoming message.
>> Checked by AVG.
>> Version: 7.5.526 / Virus Database: 270.5.0/1556 - Release Date: 7/16/2008 4:56 PM
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Feedback for Bayeux contribution
Posted by Costin Manolache <co...@gmail.com>.
On Thu, Jul 17, 2008 at 7:00 AM, Filip Hanik - Dev Lists <de...@hanik.com>
wrote:
> Remy Maucherat wrote:
>
>> On Thu, 2008-07-17 at 07:39 -0400, Yoav Shapira wrote:
>>
>>
>>> On Wed, Jul 16, 2008 at 9:47 PM, Filip Hanik - Dev Lists
>>> <de...@hanik.com> wrote:
>>>
>>>
>>>> I'd like some feedback on the contribution, before I call for a vote for
>>>> inclusion
>>>>
>>>> thanks
>>>> Filip
>>>>
>>>> bugzilla@apache.org wrote:
>>>>
>>>>
>>>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=45413
>>>>>
>>>>>
>>>> I'm happy to welcome this contribution. It's refreshingly cool.
>>>
>>>
>>
>> OTOH, I haven't heard anything about bayeux lately. Is it actually
>> picking up enough adoption to be included with Tomcat ?
>>
>>
> I'd follow Costin's advice, have it be a separate component, if it does
> become popular, it can be considered for inclusion then
>
Great, thank you.
I assume the first step is to check in the code in tomcat ( based on the bug
layout - looks like separate dir, which is probably better in this case ).
After that it'll follow the normal process for a release - and I hope you'll
add more to README at least before release.
Few more questions:
I would guess that only part of it is specific to tomcat ( connector
interface ) - do you plan to have it support other servlet engines as well (
wouldn't be a bad idea if you want adoption for your API - or bayeux ) ?
What kind of config is needed - and if any, is it in server.xml or can it be
done via web.xml in apps that use it ?
What kind of monitoring do you have/plan - didn't see any JMX. I guess it'll
affect the number of open connections.
Costin
>
> Filip
>
>
> Rémy
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
Re: Feedback for Bayeux contribution
Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
Remy Maucherat wrote:
> On Thu, 2008-07-17 at 07:39 -0400, Yoav Shapira wrote:
>
>> On Wed, Jul 16, 2008 at 9:47 PM, Filip Hanik - Dev Lists
>> <de...@hanik.com> wrote:
>>
>>> I'd like some feedback on the contribution, before I call for a vote for
>>> inclusion
>>>
>>> thanks
>>> Filip
>>>
>>> bugzilla@apache.org wrote:
>>>
>>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=45413
>>>>
>> I'm happy to welcome this contribution. It's refreshingly cool.
>>
>
> OTOH, I haven't heard anything about bayeux lately. Is it actually
> picking up enough adoption to be included with Tomcat ?
>
I'd follow Costin's advice, have it be a separate component, if it does
become popular, it can be considered for inclusion then
Filip
> Rémy
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Feedback for Bayeux contribution
Posted by Remy Maucherat <re...@apache.org>.
On Thu, 2008-07-17 at 07:39 -0400, Yoav Shapira wrote:
> On Wed, Jul 16, 2008 at 9:47 PM, Filip Hanik - Dev Lists
> <de...@hanik.com> wrote:
> > I'd like some feedback on the contribution, before I call for a vote for
> > inclusion
> >
> > thanks
> > Filip
> >
> > bugzilla@apache.org wrote:
> >>
> >> https://issues.apache.org/bugzilla/show_bug.cgi?id=45413
>
> I'm happy to welcome this contribution. It's refreshingly cool.
OTOH, I haven't heard anything about bayeux lately. Is it actually
picking up enough adoption to be included with Tomcat ?
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Feedback for Bayeux contribution
Posted by Yoav Shapira <yo...@apache.org>.
On Wed, Jul 16, 2008 at 9:47 PM, Filip Hanik - Dev Lists
<de...@hanik.com> wrote:
> I'd like some feedback on the contribution, before I call for a vote for
> inclusion
>
> thanks
> Filip
>
> bugzilla@apache.org wrote:
>>
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=45413
I'm happy to welcome this contribution. It's refreshingly cool.
Yoav
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Feedback for Bayeux contribution
Posted by Peter Rossbach <pr...@objektpark.de>.
Hi Filip and Guy,
great news +1 to commit the bayeux stuff. It was a big step to show
the usage of async programming style.
Peter
Am 17.07.2008 um 03:47 schrieb Filip Hanik - Dev Lists:
> I'd like some feedback on the contribution, before I call for a
> vote for inclusion
>
> thanks
> Filip
>
> bugzilla@apache.org wrote:
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=45413
>>
>> Summary: Contribution of Bayeux implementation for Tomcat
>> Product: Tomcat 6
>> Version: 6.0.16
>> Platform: All
>> URL: http://svn.hanik.com/svn/repos/tomcat-bayeux
>> OS/Version: All
>> Status: NEW
>> Severity: enhancement
>> Priority: P2
>> Component: Catalina
>> AssignedTo: tomcat-dev@jakarta.apache.org
>> ReportedBy: fhanik@apache.org
>>
>>
>> Created an attachment (id=22267)
>> --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22267)
>> Contribution of code
>>
>> The following bugzilla issue is a contribution of a codebase from
>> Filip
>> Hanik(asf:fhanik) and Guy Molinari(individual)
>> Both have ICLAs on file with the ASF.
>>
>> Description:
>> The contribution is two fold
>>
>> 1. The core implementation
>> Core implementation of the Bayeux protocol using Comet and HTTP
>> External dependencies: json.jar from json.org - Apache License 2.0
>> packages: - org.apache.cometd.bayeux APIs for web application
>> developers
>> derived from a proposed but incomplete API by Dojo Foundation
>> - org.apache.tomcat.bayeux
>> implementation of API classes
>>
>> 2. The sample applications
>> External dependencies: Dojo Toolkit, license:
>> http://trac.dojotoolkit.org/browser/dojo/trunk/LICENSE#L13
>>
>> COPYRIGHT and LICENSE files included.
>>
>> The contribution is a full environment, to be able to download and
>> build
>> distributions. We don't expect everything to be merged in, instead
>> we expect
>> that the source code be integrated into tomcat/trunk and we can
>> then modify the
>> existing build scripts to fit into the Tomcat build/distribution
>> scheme
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>