[GitHub] [camel] McIntozh commented on pull request #8896: Adding HTTPs support to AS2 component

["McIntozh (via GitHub)" <gi...@apache.org>]

McIntozh commented on PR #8896:
URL: https://github.com/apache/camel/pull/8896#issuecomment-1410014085

   @shikhar97gupta, I was able to implement your changes in the current v4 main branch:
   [Compare McIntozh/CAMEL-17946 to main](https://github.com/apache/camel/compare/main...McIntozh:camel:CAMEL-17946)
   Unfortunately I found, that your solution only works when the host (like "localhost" in your modified unit test) is trusted by the default HostNameVerifier.
   I checked against the mendelson test instance at http://mendelson.de/as2_testserver which uses a self signed cerificate and I only got it to work, applying a NoopHostnameVerifier in the component. I don't think we should hard code a NoopHostnameVerifier here. Maybe the verifier should also be supplied via configuration?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org