You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Claudio Martella (Created) (JIRA)" <ji...@apache.org> on 2012/01/08 23:52:39 UTC
[jira] [Created] (GIRAPH-121) BasicVertexResolver should
implementation and VertexResolver should be interface
BasicVertexResolver should implementation and VertexResolver should be interface
--------------------------------------------------------------------------------
Key: GIRAPH-121
URL: https://issues.apache.org/jira/browse/GIRAPH-121
Project: Giraph
Issue Type: Improvement
Components: graph
Affects Versions: 0.70.0
Reporter: Claudio Martella
Assignee: Claudio Martella
Priority: Trivial
After change of naming in Vertex, VertexResolver and BasicVertexResolver naming should be synched.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-121) BasicVertexResolver should be
implementation and VertexResolver should be interface
Posted by "Claudio Martella (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285835#comment-13285835 ]
Claudio Martella commented on GIRAPH-121:
-----------------------------------------
I'm having some troubles downloading the patch. Are you sure the upload got it right?
> BasicVertexResolver should be implementation and VertexResolver should be interface
> -----------------------------------------------------------------------------------
>
> Key: GIRAPH-121
> URL: https://issues.apache.org/jira/browse/GIRAPH-121
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.1.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Priority: Trivial
> Labels: newbie
>
> After the change of naming in Vertex, VertexResolver and BasicVertexResolver naming should be synched.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-121) BasicVertexResolver should be
implementation and VertexResolver should be interface
Posted by "Paolo Castagna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paolo Castagna updated GIRAPH-121:
----------------------------------
Attachment: GIRAPH-121.patch
This is incomplete, it remains to be decided what to do about VertexResolver interface and setGraphState method (which is used in BsbUtils).
Claudio, what do you think?
> BasicVertexResolver should be implementation and VertexResolver should be interface
> -----------------------------------------------------------------------------------
>
> Key: GIRAPH-121
> URL: https://issues.apache.org/jira/browse/GIRAPH-121
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.1.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Priority: Trivial
> Labels: newbie
> Attachments: GIRAPH-121.patch
>
>
> After the change of naming in Vertex, VertexResolver and BasicVertexResolver naming should be synched.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-121) BasicVertexResolver should be
implementation and VertexResolver should be interface
Posted by "Claudio Martella (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claudio Martella updated GIRAPH-121:
------------------------------------
Description: After the change of naming in Vertex, VertexResolver and BasicVertexResolver naming should be synched. (was: After change of naming in Vertex, VertexResolver and BasicVertexResolver naming should be synched.)
Summary: BasicVertexResolver should be implementation and VertexResolver should be interface (was: BasicVertexResolver should implementation and VertexResolver should be interface)
> BasicVertexResolver should be implementation and VertexResolver should be interface
> -----------------------------------------------------------------------------------
>
> Key: GIRAPH-121
> URL: https://issues.apache.org/jira/browse/GIRAPH-121
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.70.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Priority: Trivial
> Labels: newbie
>
> After the change of naming in Vertex, VertexResolver and BasicVertexResolver naming should be synched.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-121) BasicVertexResolver should be
implementation and VertexResolver should be interface
Posted by "Claudio Martella (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285736#comment-13285736 ]
Claudio Martella commented on GIRAPH-121:
-----------------------------------------
Yes, I'd say we can add the setGraphState() method to the interface, just like in other places around.
> BasicVertexResolver should be implementation and VertexResolver should be interface
> -----------------------------------------------------------------------------------
>
> Key: GIRAPH-121
> URL: https://issues.apache.org/jira/browse/GIRAPH-121
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.1.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Priority: Trivial
> Labels: newbie
> Attachments: GIRAPH-121.patch
>
>
> After the change of naming in Vertex, VertexResolver and BasicVertexResolver naming should be synched.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-121) BasicVertexResolver should be
implementation and VertexResolver should be interface
Posted by "Paolo Castagna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paolo Castagna updated GIRAPH-121:
----------------------------------
Attachment: (was: GIRAPH-121.patch)
> BasicVertexResolver should be implementation and VertexResolver should be interface
> -----------------------------------------------------------------------------------
>
> Key: GIRAPH-121
> URL: https://issues.apache.org/jira/browse/GIRAPH-121
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.1.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Priority: Trivial
> Labels: newbie
>
> After the change of naming in Vertex, VertexResolver and BasicVertexResolver naming should be synched.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-121) BasicVertexResolver should be
implementation and VertexResolver should be interface
Posted by "Paolo Castagna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285662#comment-13285662 ]
Paolo Castagna commented on GIRAPH-121:
---------------------------------------
This is 'trivial' however there is a small problem: should the setGraphState() method be added to the VertexResolver interface?
{code:java}
@SuppressWarnings("rawtypes")
public static <I extends WritableComparable, V extends Writable,
E extends Writable, M extends Writable> VertexResolver<I, V, E, M>
createVertexResolver(Configuration conf,
GraphState<I, V, E, M> graphState) {
Class<? extends VertexResolver<I, V, E, M>> vertexResolverClass =
getVertexResolverClass(conf);
VertexResolver<I, V, E, M> resolver =
ReflectionUtils.newInstance(vertexResolverClass, conf);
resolver.setGraphState(graphState);
return resolver;
}
{code}
> BasicVertexResolver should be implementation and VertexResolver should be interface
> -----------------------------------------------------------------------------------
>
> Key: GIRAPH-121
> URL: https://issues.apache.org/jira/browse/GIRAPH-121
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.1.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Priority: Trivial
> Labels: newbie
>
> After the change of naming in Vertex, VertexResolver and BasicVertexResolver naming should be synched.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-121) BasicVertexResolver should be
implementation and VertexResolver should be interface
Posted by "Paolo Castagna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paolo Castagna updated GIRAPH-121:
----------------------------------
Attachment: GIRAPH-121.patch
Ok, Claudio. This is what I got, unfortunately there are a few tests failing and I really don't see why.
It should be trivial, but generics + reflection + working with munge is giving me some troubles.
> BasicVertexResolver should be implementation and VertexResolver should be interface
> -----------------------------------------------------------------------------------
>
> Key: GIRAPH-121
> URL: https://issues.apache.org/jira/browse/GIRAPH-121
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.1.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Priority: Trivial
> Labels: newbie
> Attachments: GIRAPH-121.patch
>
>
> After the change of naming in Vertex, VertexResolver and BasicVertexResolver naming should be synched.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-121) BasicVertexResolver should be
implementation and VertexResolver should be interface
Posted by "Maja Kabiljo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409698#comment-13409698 ]
Maja Kabiljo commented on GIRAPH-121:
-------------------------------------
You are having a problem because of
{noformat}ReflectionUtils.<VertexResolver>getTypeArguments(VertexResolver.class, vertexResolverClass);{noformat}
from GraphMapper. This method doesn't work if the first argument is interface. If you make VertexResolver to be an abstract class tests pass.
Also, I think that in BspUtils you should call
{noformat}conf.getClass(GiraphJob.VERTEX_RESOLVER_CLASS, BasicVertexResolver.class, VertexResolver.class);{noformat}
> BasicVertexResolver should be implementation and VertexResolver should be interface
> -----------------------------------------------------------------------------------
>
> Key: GIRAPH-121
> URL: https://issues.apache.org/jira/browse/GIRAPH-121
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.1.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Priority: Trivial
> Labels: newbie
> Attachments: GIRAPH-121.patch
>
>
> After the change of naming in Vertex, VertexResolver and BasicVertexResolver naming should be synched.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira