You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/16 08:33:18 UTC

[GitHub] [tvm-rfcs] u99127 commented on pull request #30: Command Line Configuration Files

u99127 commented on pull request #30:
URL: https://github.com/apache/tvm-rfcs/pull/30#issuecomment-920701756


   > Can you address the common usage of environment variables for configuration, why that wasn't considered, and the potential for future work?
   
   I think the usage of environment variables for configuration of this kind in an AoT compilation flow with tvmc is quite debatable with the kinds of things it takes. .
   
   Personally I think its cleaner to consider this directly in configuration files of this kind. 
   
   I have had a read through and this looks pretty good LGTM
   
   @leandron  could you please take a look ? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org