[GitHub] [nifi] mattyb149 commented on a diff in pull request #5900: NIFI-7234 Standardized on Avro 1.11.0

[GitBox <gi...@apache.org>]

mattyb149 commented on code in PR #5900:
URL: https://github.com/apache/nifi/pull/5900#discussion_r844355311


##########
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/avro/AvroTypeUtil.java:
##########
@@ -326,7 +326,7 @@ private static Schema nullable(final Schema schema) {
             return Schema.createUnion(unionTypes);
         }
 
-        return Schema.createUnion(Schema.create(Type.NULL), schema);
+        return Schema.createUnion(schema, Schema.create(Type.NULL));

Review Comment:
   Does this affect fields for which the default value is `null`? I read in a couple of places (perhaps out of date) that in order to have a default value of `null`, then `null` has to be the first type in the union. Is that no longer the case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org