[GitHub] [hbase] nyl3532016 commented on a change in pull request #3202: HBASE-25803 Add compaction offload switch

[GitBox <gi...@apache.org>]

nyl3532016 commented on a change in pull request #3202:
URL: https://github.com/apache/hbase/pull/3202#discussion_r621124076



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -705,6 +705,17 @@ void majorCompact(TableName tableName, byte[] columnFamily, CompactType compactT
   Map<ServerName, Boolean> compactionSwitch(boolean switchState, List<String> serverNamesList)
       throws IOException;
 
+  /**
+   * Turn the compaction offload on or off. This state is ephemeral. The setting will be lost on
+   * restart.
+   * @param switchState Set to <code>true</code> to enable, <code>false</code> to disable.
+   * @param serverNamesList list of region servers.
+   * @return Previous compaction offload states for region servers
+   * @throws IOException if a remote or network exception occurs
+   */
+  Map<ServerName, Boolean> compactionOffloadSwitch(boolean switchState, List<String> serverNamesList)

Review comment:
       This api can change compaction execution strategy for specific regionservers conveniently. 
   It's useful, isn't it ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org