You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by "jamesfredley (via GitHub)" <gi...@apache.org> on 2026/05/02 15:07:50 UTC
[PR] Strengthen guide page polish: visible borders, contrast, dark title chips [grails-static-website]
jamesfredley opened a new pull request, #477:
URL: https://github.com/apache/grails-static-website/pull/477
## Summary
Earlier polish in #475 was technically applied but visually subtle to the point of being imperceptible (sub-pixel border, 4%-darker background). This pass makes the changes obvious.
## Image blocks
- 1px solid border (`#d0d7de`) + 6px rounded corners + subtle box-shadow so screenshots read as figures rather than floating bitmaps
- Increased margin around `.imageblock` to breathe better
- `!important` on `max-width`/`height` to defeat any inherited img rules from legacy site CSS
## Code blocks
- Stronger background (`#f6f8fa` GitHub-light) with 1px solid border (`#d0d7de`)
- Larger padding (18x20px)
- Subtle box-shadow for depth
- **Dark title chip**: the `.title` that names the file above the code is now a dark monospace pill (`#1f2328` bg, `#f6f8fa` text) that visually connects to the code body with a square top-left corner. Reads as a proper code panel.
- `!important` on every property to defeat the inherited `.listing-block` typo rule and any centering inherited from `.content`
## Inline code
- More contrast: `#eaeef2` background with `#d0d7de` border
- 4-corner `border-radius: 4px`, `0.875em` monospace
- Now also styles `<code>` inside `<td>` and `<a>`
## Verification
Local DOM data confirms rules apply with `!important` priority. Live verification on next cron publish. If still too subtle, easy to iterate.
(refs apache/grails-static-website#354)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Strengthen guide page polish: visible borders, contrast, dark title chips [grails-static-website]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley merged PR #477:
URL: https://github.com/apache/grails-static-website/pull/477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org