You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Jukka Zitting <ju...@gmail.com> on 2014/01/07 17:34:52 UTC
Access control test failures (Was: Release Apache Jackrabbit Oak 0.14)
Hi,
On Tue, Jan 7, 2014 at 9:52 AM, Julian Reschke <ju...@gmx.de> wrote:
> It would be awesome if we could prioritize this issue somewhat ... higher.
> It's hard to develop code in a project that constantly fails on the
> regression tests.
Indeed. I'll give this another shot now.
It looks like my earlier work on OAK-1247 helped somewhat, so I might
be on the correct track here.
BR,
Jukka Zitting
Re: Access control test failures (Was: Release Apache Jackrabbit
Oak 0.14)
Posted by Julian Reschke <ju...@gmx.de>.
On 2014-01-09 23:25, Tobias Bocanegra wrote:
> I found the problem and updated
> https://issues.apache.org/jira/browse/OAK-1311 with the reasoning.
>
> regards, toby
> ...
Thanks, Toby!
Interesting enough, differences in timer resolution were the cause for a
jackrabbit (trunk) test case failure that I fixed Tuesday (but here the
bug was in the test). This is definitively something to keep in mind.
Best regards, Julian
Re: Access control test failures (Was: Release Apache Jackrabbit Oak 0.14)
Posted by Tobias Bocanegra <tr...@adobe.com>.
I found the problem and updated
https://issues.apache.org/jira/browse/OAK-1311 with the reasoning.
regards, toby
On Thu, Jan 9, 2014 at 10:19 AM, Jukka Zitting <ju...@gmail.com>wrote:
> Hi,
>
> On Thu, Jan 9, 2014 at 12:13 AM, Tobias Bocanegra <tr...@apache.org>
> wrote:
> > I will disable the cache and work on it tomorrow.
>
> Verified that r1556724 fixed the issue. My test build that reproduces
> the issue about 30% of the time ran 50 times without failing.
>
> BR,
>
> Jukka Zitting
>
Re: Access control test failures (Was: Release Apache Jackrabbit Oak 0.14)
Posted by Jukka Zitting <ju...@gmail.com>.
Hi,
On Thu, Jan 9, 2014 at 12:13 AM, Tobias Bocanegra <tr...@apache.org> wrote:
> I will disable the cache and work on it tomorrow.
Verified that r1556724 fixed the issue. My test build that reproduces
the issue about 30% of the time ran 50 times without failing.
BR,
Jukka Zitting
Re: Access control test failures (Was: Release Apache Jackrabbit Oak 0.14)
Posted by Tobias Bocanegra <tr...@apache.org>.
I tested it on the Windows VM and now I can reproduce it and I'm
always getting an error:
$mvn test -pl oak-jcr
-Dtest=org.apache.jackrabbit.oak.jcr.security.authorization.AccessControlManagementTest
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.jackrabbit.oak.jcr.security.authorization.AccessControlManagementTest
Tests run: 16, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 4.618
sec <<< FAILURE!
But never on my Mac.
The test is so simple that I can't really think of what the problem
could be. no observation, no timing involved....maybe a hashcode
issue.
I will disable the cache and work on it tomorrow.
regards, toby
On Wed, Jan 8, 2014 at 2:52 PM, Tobias Bocanegra <tr...@apache.org> wrote:
> On Wed, Jan 8, 2014 at 2:36 PM, Julian Reschke <ju...@gmx.de> wrote:
>> On 2014-01-08 23:30, Tobias Bocanegra wrote:
>>>
>>> Hi,
>>>
>>> I can't reproduce the error on my box - it's probably too fast :-)
>>
>>
>> Not likely :-)
>>
>> Maybe it has to do with the number of actual cores,
> I have 8.
>
>
>> the OS threading
>> behaviour, or timer resolutions...
>
> however, the observation tests fail on the windows VM because they
> timeout. I'll try increasing the wait time.
> regards, toby
>
>>
>>
>> Best regards, Julian
Re: Access control test failures (Was: Release Apache Jackrabbit Oak 0.14)
Posted by Tobias Bocanegra <tr...@apache.org>.
On Wed, Jan 8, 2014 at 2:36 PM, Julian Reschke <ju...@gmx.de> wrote:
> On 2014-01-08 23:30, Tobias Bocanegra wrote:
>>
>> Hi,
>>
>> I can't reproduce the error on my box - it's probably too fast :-)
>
>
> Not likely :-)
>
> Maybe it has to do with the number of actual cores,
I have 8.
> the OS threading
> behaviour, or timer resolutions...
however, the observation tests fail on the windows VM because they
timeout. I'll try increasing the wait time.
regards, toby
>
>
> Best regards, Julian
Re: Access control test failures (Was: Release Apache Jackrabbit
Oak 0.14)
Posted by Julian Reschke <ju...@gmx.de>.
On 2014-01-08 23:30, Tobias Bocanegra wrote:
> Hi,
>
> I can't reproduce the error on my box - it's probably too fast :-)
Not likely :-)
Maybe it has to do with the number of actual cores, the OS threading
behaviour, or timer resolutions...
Best regards, Julian
Re: Access control test failures (Was: Release Apache Jackrabbit Oak 0.14)
Posted by Tobias Bocanegra <tr...@apache.org>.
Hi,
I can't reproduce the error on my box - it's probably too fast :-)
however, I try to run the tests in a windows 7 VM, but here I get
other errors, like:
Failed tests:
concurrentObservers(org.apache.jackrabbit.oak.spi.commit.BackgroundObserverTest)
Tests in error:
testPermissionPropagation(org.apache.jackrabbit.oak.security.authorization.permission.ClusterPermissionsTest):
org.apache.jackrabbit.oak.api.CommitFailedException: OakMerge0001:
Failed to mergees to the underlying MicroKernel
Tests run: 1523, Failures: 1, Errors: 1, Skipped: 65
I'll try harder.... :-)
Oh, and on Mac I now get:
Tests in error:
testImportWithIntermediatePath(org.apache.jackrabbit.oak.jcr.security.user.UserImportTest):
Java heap space
testImportWithIntermediatePath(org.apache.jackrabbit.oak.jcr.security.user.UserImportTest)
testImportImpersonation(org.apache.jackrabbit.oak.jcr.security.user.UserImportTest):
Java heap space
testImportImpersonation(org.apache.jackrabbit.oak.jcr.security.user.UserImportTest)
Regards, Toby
On Wed, Jan 8, 2014 at 6:19 AM, Jukka Zitting <ju...@gmail.com> wrote:
> Hi,
>
> On Wed, Jan 8, 2014 at 5:10 AM, Julian Reschke <ju...@gmx.de> wrote:
>> Jukka, thanks for investigating! The tests now reliably pass on my machines.
>
> Great, thanks for verifying!
>
> BR,
>
> Jukka Zitting
Re: Access control test failures (Was: Release Apache Jackrabbit Oak 0.14)
Posted by Jukka Zitting <ju...@gmail.com>.
Hi,
On Wed, Jan 8, 2014 at 5:10 AM, Julian Reschke <ju...@gmx.de> wrote:
> Jukka, thanks for investigating! The tests now reliably pass on my machines.
Great, thanks for verifying!
BR,
Jukka Zitting
Re: Access control test failures (Was: Release Apache Jackrabbit
Oak 0.14)
Posted by Julian Reschke <ju...@gmx.de>.
On 2014-01-07 17:34, Jukka Zitting wrote:
> Hi,
>
> On Tue, Jan 7, 2014 at 9:52 AM, Julian Reschke <ju...@gmx.de> wrote:
>> It would be awesome if we could prioritize this issue somewhat ... higher.
>> It's hard to develop code in a project that constantly fails on the
>> regression tests.
>
> Indeed. I'll give this another shot now.
>
> It looks like my earlier work on OAK-1247 helped somewhat, so I might
> be on the correct track here.
>
> BR,
>
> Jukka Zitting
Jukka, thanks for investigating! The tests now reliably pass on my machines.
Best regards, Julian