[jira] [Commented] (CXF-6424) AbstractLoggingInterceptor tests and improvements

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-6424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659684#comment-16659684 ] 

ASF GitHub Bot commented on CXF-6424:
-------------------------------------

skjolber closed pull request #76: [CXF-6424] AbstractLoggingInterceptor tests and improvements
URL: https://github.com/apache/cxf/pull/76
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> AbstractLoggingInterceptor tests and improvements
> -------------------------------------------------
>
>                 Key: CXF-6424
>                 URL: https://issues.apache.org/jira/browse/CXF-6424
>             Project: CXF
>          Issue Type: Improvement
>          Components: logging
>            Reporter: Thomas Skjølberg
>            Priority: Minor
>
> Improvements for AbstractLoggingInterceptor: 
> 1. fall back to logging raw XML payload if pretty-printing fails
> 2. ensure capacity in the output based on the raw XML string size
> 3. write directly (and improve performance) to the output StringBuilder using custom Writer
> 4. read directly (and improve performance) from the StringWriter buffer using custom Reader
> 5. contruct XMLStreamReader directly rather than going via Source
> 6. do not call XMLStreamWriter.close() before getting contents for truncated or invalid XML because some writers misbehave (are extra helpful) in a way unfit for logging. 
> 7. additional javadoc / comments
> 8. additional test cases



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)