You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/12/30 07:00:56 UTC
[GitHub] [tvm] lightzhan-intellif opened a new pull request, #13673: Fix the issue that pylance emits the warnning 'Code is unreachable' f…
lightzhan-intellif opened a new pull request, #13673:
URL: https://github.com/apache/tvm/pull/13673
For the users who use vscode to write code, Pylance in vscode will shadow the code below the function calls `tvm.ir.load_json/save_json` and tell users "Code is unreachable" like the picture below:
The issue maybe confuses users and make the code a little "dirty".
This PR fixes this by adding a return type hint to the functions `load_json` and `save_json`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #13673: [BugFix] Pylance emits the warnning 'Code is unreachable'
Posted by GitBox <gi...@apache.org>.
tqchen merged PR #13673:
URL: https://github.com/apache/tvm/pull/13673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13673: Fix the issue that pylance emits the warnning 'Code is unreachable' f…
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13673:
URL: https://github.com/apache/tvm/pull/13673#issuecomment-1367758307
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to auto-tag found, no teams are specified in PR title <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org