You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2017/05/12 12:41:47 UTC
[GitHub] flink pull request #3885: [FLINK-6552] Allow differing types for side output...
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3885
[FLINK-6552] Allow differing types for side outputs
R: @zentol
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink jira-6552-fix-side-output-types
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3885.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3885
----
commit aef59811512c60bf4111ddac076ecbf8166ec947
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2017-05-12T12:40:44Z
[FLINK-6552] Allow differing types for side outputs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3885: [FLINK-6552] Allow differing types for side outputs
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3885
Merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3885: [FLINK-6552] Allow differing types for side output...
Posted by tedyu <gi...@git.apache.org>.
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/3885#discussion_r116611287
--- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java ---
@@ -318,9 +318,10 @@ public void addVirtualSideOutputNode(Integer originalId, Integer virtualId, Outp
continue;
}
- if (!tag.f1.getTypeInfo().equals(outputTag.getTypeInfo())) {
- throw new IllegalArgumentException("Trying to add a side input for the same id " +
- "with a different type. This is not allowed.");
+ if (tag.f1.getId().equals(outputTag.getId()) &&
+ !tag.f1.getTypeInfo().equals(outputTag.getTypeInfo())) {
+ throw new IllegalArgumentException("Trying to add a side output for the same" +
--- End diff --
minor: missing space after "same"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3885: [FLINK-6552] Allow differing types for side output...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3885#discussion_r116488176
--- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java ---
@@ -318,9 +318,10 @@ public void addVirtualSideOutputNode(Integer originalId, Integer virtualId, Outp
continue;
}
- if (!tag.f1.getTypeInfo().equals(outputTag.getTypeInfo())) {
- throw new IllegalArgumentException("Trying to add a side input for the same id " +
- "with a different type. This is not allowed.");
+ if (tag.f1.getId().equals(outputTag.getId()) &&
+ !tag.f1.getTypeInfo().equals(outputTag.getTypeInfo())) {
+ throw new IllegalArgumentException("Trying to add a side output for the same" +
+ "side-output id with a different type. This is not allowed.");
--- End diff --
Could also include the tag name for good measure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3885: [FLINK-6552] Allow differing types for side outputs
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3885
You're right. 😓 I'm fixing and then merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3885: [FLINK-6552] Allow differing types for side outputs
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3885
Thanks @tedyu and @zentol! I pushed another commit with these minor fixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3885: [FLINK-6552] Allow differing types for side output...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/3885
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---