You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "gxxiong (via GitHub)" <gi...@apache.org> on 2023/02/04 03:32:41 UTC

[GitHub] [shardingsphere] gxxiong opened a new pull request, #23990: Refactor: splitting ral-integration-test-cases.xml file

gxxiong opened a new pull request, #23990:
URL: https://github.com/apache/shardingsphere/pull/23990

   Ref #23645.
   
   Changes proposed in this pull request:
     -splitting ral-integration-test-cases.xml file
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [X] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [X] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [X] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu merged pull request #23990: Refactor: splitting ral-integration-test-cases.xml file

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #23990:
URL: https://github.com/apache/shardingsphere/pull/23990


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #23990: Refactor: splitting ral-integration-test-cases.xml file

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on code in PR #23990:
URL: https://github.com/apache/shardingsphere/pull/23990#discussion_r1096494017


##########
test/e2e/suite/src/test/resources/cases/ral/ral-integration-queryable.xml:
##########
@@ -14,114 +15,60 @@
   ~ See the License for the specific language governing permissions and
   ~ limitations under the License.
   -->
-<integration-test-cases>
-    <test-case sql="SHOW READWRITE_SPLITTING HINT STATUS">
-        <assertion expected-data-file="default_readwrite_splitting_hint.xml" />
-        <assertion expected-data-file="set_readwrite_splitting_hint.xml">
-            <initial-sql sql="SET READWRITE_SPLITTING HINT SOURCE = write" />
-            <destroy-sql sql="CLEAR READWRITE_SPLITTING HINT" />
-        </assertion>
-        <assertion expected-data-file="default_readwrite_splitting_hint.xml">
-            <initial-sql sql="SET READWRITE_SPLITTING HINT SOURCE = write;CLEAR READWRITE_SPLITTING HINT" />
-        </assertion>
-        <assertion expected-data-file="default_readwrite_splitting_hint.xml">
-            <initial-sql sql="SET READWRITE_SPLITTING HINT SOURCE = write;CLEAR HINT" />
-        </assertion>
-    </test-case>
-
-    <test-case sql="SHOW SHARDING HINT STATUS">
-        <assertion expected-data-file="default_sharding_hint.xml" />
-        <assertion expected-data-file="set_database_value_hint.xml">
-            <initial-sql sql="SET SHARDING HINT DATABASE_VALUE = 100" />
-            <destroy-sql sql="CLEAR SHARDING HINT" />
-        </assertion>
-        <assertion expected-data-file="add_database_value_hint.xml">
-            <initial-sql sql="ADD SHARDING HINT DATABASE_VALUE t_user_item= 100" />
-            <destroy-sql sql="CLEAR SHARDING HINT" />
-        </assertion>
-        <assertion expected-data-file="add_table_value_hint.xml">
-            <initial-sql sql="ADD SHARDING HINT TABLE_VALUE t_user_item = 100" />
-        </assertion>
-        <assertion expected-data-file="default_sharding_hint.xml">
-            <initial-sql sql="ADD SHARDING HINT TABLE_VALUE t_user_item= 100;CLEAR SHARDING HINT" />
-        </assertion>
-        <assertion expected-data-file="default_sharding_hint.xml">
-            <initial-sql sql="ADD SHARDING HINT TABLE_VALUE t_user_item= 100;CLEAR HINT" />
-        </assertion>
-    </test-case>
 
+<integration-test-cases>

Review Comment:
   Can you split this file to `ral-integration-preview.xml` and `ral-integration-show.xml`



##########
test/e2e/suite/src/test/resources/cases/ral/ral-integration-updatable.xml:
##########
@@ -0,0 +1,39 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements.  See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to You under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License.  You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+
+<integration-test-cases>
+    <test-case sql="REFRESH DATABASE METADATA FROM GOVERNANCE CENTER" db-types="MySQL">

Review Comment:
   Can you split this file to `ral-integration-refresh.xml` and `ral-integration-set.xml`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org