[jira] [Work logged] (BEAM-6597) Put MonitoringInfos/metrics in the Java SDK ProcessBundleProgressResponse

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-6597?focusedWorklogId=425931&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425931 ]

ASF GitHub Bot logged work on BEAM-6597:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Apr/20 23:21
            Start Date: 21/Apr/20 23:21
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on issue #11487:
URL: https://github.com/apache/beam/pull/11487#issuecomment-617461562


   R: @ajamato 
   CC: @boyuanzz @ananvay 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 425931)
    Time Spent: 20m  (was: 10m)

> Put MonitoringInfos/metrics in the Java SDK ProcessBundleProgressResponse
> -------------------------------------------------------------------------
>
>                 Key: BEAM-6597
>                 URL: https://issues.apache.org/jira/browse/BEAM-6597
>             Project: Beam
>          Issue Type: New Feature
>          Components: java-fn-execution
>            Reporter: Alex Amato
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> I think this is the correct approach, as I don't believe there is any hook in the Java SDK yet for ProcessBundleProgressResponses.
> (1) Implement ProcessBundleProgressResponse
> See FnHarness.main to add a handle for RequestCase.PROGRESS_BUNDLE.
> (2) Refactor ProgressBundleHandler so that the metrics can be extracted from the MetricContainerStep map and SimpleExecutionStates for the instrucitonId when the call comes in. (Right now all these objects only live in the local function, they may need to live in an object instead which can be accessed by both process bundle and progress bundle responses). Be careful to not introduce thread contention. Ideally we need a way to read the values without locking new ones from being written.
> (Test 1) Also be sure to simplify RemoteExecutionTest.testMetrics().
> By inspecting the metric progress, we can remove the sleeps from this code. Currently there are sleeps in start, process and finish to ensure execution time metrics are added. Instead, once progress bundle responses are introduced, the metrics can be examined here



--
This message was sent by Atlassian Jira
(v8.3.4#803005)