You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/26 08:30:31 UTC

[GitHub] [flink] leonardBang opened a new pull request #17356: [FLINK-23313][docs] Reintroduce temporal table function documentation

leonardBang opened a new pull request #17356:
URL: https://github.com/apache/flink/pull/17356


   ## What is the purpose of the change
   
   * This pull request reintroduce the temporal table function documentation,  the temporal table function feature has never been deprecated but the documentation was deleted when simplify the SQL concepts documentation in FLINK-20456. 
   
   ## Brief change log
   
     - Reintroduce the documentation of `temporal table function`
     - Fix typo in `tableApi.md`
   
   
   ## Verifying this change
   
   This change is a documentation change without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): ( no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leonardBang commented on pull request #17356: [FLINK-23313][docs] Reintroduce temporal table function documentation

Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #17356:
URL: https://github.com/apache/flink/pull/17356#issuecomment-929697815


   That's great if you can help merge @sjwiesman ,  thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leonardBang commented on pull request #17356: [FLINK-23313][docs] Reintroduce temporal table function documentation

Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #17356:
URL: https://github.com/apache/flink/pull/17356#issuecomment-929697815


   That's great if you can help merge @sjwiesman ,  thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17356: [FLINK-23313][docs] Reintroduce temporal table function documentation

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17356:
URL: https://github.com/apache/flink/pull/17356#issuecomment-927259603


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 7e9dc5baa8fac341a8f5131bbcd4b3ab1a68b8fb (Sun Sep 26 08:32:38 UTC 2021)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sjwiesman commented on pull request #17356: [FLINK-23313][docs] Reintroduce temporal table function documentation

Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #17356:
URL: https://github.com/apache/flink/pull/17356#issuecomment-929285508


   This looks good to me. @leonardBang should we backport this to 1.14? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17356: [FLINK-23313][docs] Reintroduce temporal table function documentation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17356:
URL: https://github.com/apache/flink/pull/17356#issuecomment-927266300


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e9dc5baa8fac341a8f5131bbcd4b3ab1a68b8fb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24507",
       "triggerID" : "7e9dc5baa8fac341a8f5131bbcd4b3ab1a68b8fb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7e9dc5baa8fac341a8f5131bbcd4b3ab1a68b8fb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24507) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17356: [FLINK-23313][docs] Reintroduce temporal table function documentation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17356:
URL: https://github.com/apache/flink/pull/17356#issuecomment-927266300


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e9dc5baa8fac341a8f5131bbcd4b3ab1a68b8fb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24507",
       "triggerID" : "7e9dc5baa8fac341a8f5131bbcd4b3ab1a68b8fb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7e9dc5baa8fac341a8f5131bbcd4b3ab1a68b8fb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24507) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leonardBang commented on pull request #17356: [FLINK-23313][docs] Reintroduce temporal table function documentation

Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #17356:
URL: https://github.com/apache/flink/pull/17356#issuecomment-929331341


   > This looks good to me. @leonardBang should we backport this to 1.14?
   
   Yes,  I'll backport the PR to release-1.14 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sjwiesman closed pull request #17356: [FLINK-23313][docs] Reintroduce temporal table function documentation

Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #17356:
URL: https://github.com/apache/flink/pull/17356


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sjwiesman closed pull request #17356: [FLINK-23313][docs] Reintroduce temporal table function documentation

Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #17356:
URL: https://github.com/apache/flink/pull/17356


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17356: [FLINK-23313][docs] Reintroduce temporal table function documentation

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17356:
URL: https://github.com/apache/flink/pull/17356#issuecomment-927266300


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e9dc5baa8fac341a8f5131bbcd4b3ab1a68b8fb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7e9dc5baa8fac341a8f5131bbcd4b3ab1a68b8fb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7e9dc5baa8fac341a8f5131bbcd4b3ab1a68b8fb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sjwiesman commented on pull request #17356: [FLINK-23313][docs] Reintroduce temporal table function documentation

Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #17356:
URL: https://github.com/apache/flink/pull/17356#issuecomment-929285508


   This looks good to me. @leonardBang should we backport this to 1.14? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leonardBang commented on pull request #17356: [FLINK-23313][docs] Reintroduce temporal table function documentation

Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #17356:
URL: https://github.com/apache/flink/pull/17356#issuecomment-927259493


   cc: @wuchong @sjwiesman, Could you help review this doc change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org